Skip to content

Commit

Permalink
chore(native_storage): Set min API level to 21 (#122)
Browse files Browse the repository at this point in the history
  • Loading branch information
dnys1 committed May 2, 2024
1 parent 872bb92 commit 10c3d5f
Show file tree
Hide file tree
Showing 5 changed files with 16 additions and 4 deletions.
10 changes: 9 additions & 1 deletion .github/workflows/native_storage.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -84,14 +84,22 @@ jobs:
echo 'KERNEL=="kvm", GROUP="kvm", MODE="0666", OPTIONS+="static_node=kvm"' | sudo tee /etc/udev/rules.d/99-kvm4all.rules
sudo udevadm control --reload-rules
sudo udevadm trigger --name-match=kvm
- name: Test (Android)
- name: Test (API 31)
uses: ReactiveCircus/android-emulator-runner@6b0df4b0efb23bb0ec63d881db79aefbc976e4b2 # 2.30.1
with:
# Matches `package:jni` compileSdkVersion
# https://github.com/dart-lang/native/blob/001910c9f40d637cb25c19bb500fb89cebdf7450/pkgs/jni/android/build.gradle#L57C23-L57C25
api-level: 31
arch: x86_64
script: cd packages/native/storage/example && flutter test -d emulator integration_test/storage_test.dart
- name: Test (API 21)
uses: ReactiveCircus/android-emulator-runner@6b0df4b0efb23bb0ec63d881db79aefbc976e4b2 # 2.30.1
with:
# Minimum supported API level
# Should match build.gradle: https://github.com/celest-dev/celest/blob/main/packages/native/storage/android/build.gradle#L49
api-level: 21
arch: x86_64
script: cd packages/native/storage/example && flutter test -d emulator integration_test/storage_test.dart
test_linux:
runs-on: ubuntu-latest
timeout-minutes: 15
Expand Down
4 changes: 4 additions & 0 deletions packages/native/storage/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 0.1.4

- fix: Lower Android min API to 21 ([#121](https://github.com/celest-dev/celest/issues/121))

## 0.1.3

- chore: Migrate to jni 0.8.0 to enable isolated Android storage
Expand Down
2 changes: 1 addition & 1 deletion packages/native/storage/android/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ android {
}

defaultConfig {
minSdkVersion 23
minSdkVersion 21
consumerProguardFiles 'consumer-rules.pro'
}

Expand Down
2 changes: 1 addition & 1 deletion packages/native/storage/example/android/app/build.gradle

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/native/storage/pubspec.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: native_storage
description: A Dart-only package for accessing platform-native storage functionality.
version: 0.1.3
version: 0.1.4
repository: https://github.com/celest-dev/celest/tree/main/packages/native/storage

environment:
Expand Down

0 comments on commit 10c3d5f

Please sign in to comment.