Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

internal/eval: remove the inCache #45

Merged
merged 1 commit into from
Oct 1, 2024
Merged

internal/eval: remove the inCache #45

merged 1 commit into from
Oct 1, 2024

Commits on Oct 1, 2024

  1. internal/eval: remove the inCache 

    We don't currently have a benchmark that's telling us that we need this cache. In fact, several of our benchmarks show that for large, shallow entity graphs, the inCache actually slows down authorizations and batch evaluations because of all the extra allocation that goes on to build the map.

For deep entity graphs, such a cache might be useful, but I think instead that we'll try to put such a cache in the entity graph itself by keeping track of the transitive closure of every entity's parents. That way, the cache will be effective across multiple authorizations.

Signed-off-by: Patrick Jakubowski <[email protected]>
    @patjakdev
    patjakdev committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    8a95a23 View commit details
    Browse the repository at this point in the history