Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal/mapset: relax the constraint on the argument to MapSet.Equal to just be a Container instance #43

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

patjakdev
Copy link
Collaborator

Issue #, if available: None

Description of changes: This makes it easier to compare sets of different types.

…s to just be a Container instance

This makes it easier to compare sets of different types.

Signed-off-by: Patrick Jakubowski <[email protected]>
@patjakdev patjakdev changed the title internal/mapset: relax the constraint on the argument to MapSet.Equals to just be a Container instance internal/mapset: relax the constraint on the argument to MapSet.Equal to just be a Container instance Sep 30, 2024
@patjakdev patjakdev marked this pull request as ready for review September 30, 2024 17:59
Copy link
Collaborator

@apg apg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that we don't support infinite streams of entities by design, this seems safe to me. :)

@patjakdev patjakdev merged commit 8b860c7 into cedar-policy:main Sep 30, 2024
3 checks passed
@patjakdev patjakdev deleted the use-container-type-for-equal branch September 30, 2024 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants