Fix #110

src/cfchecker/cfchecks.py

@@ -3114,8 +3114,8 @@ def chkDescription(self, varName):
                     elif len(region_names):
                         for region in region_names:
 
-                            if not region.decode('utf-8') in list(self.region_name_lh.list):
-                                self._add_error("Invalid region name: {}".format(region.decode('utf-8')),
+                            if not region.tolist().decode('utf-8') in list(self.region_name_lh.list):
+                                self._add_error("Invalid region name: {}".format(region.tolist().decode('utf-8')),
                                                 varName,
                                                 code="3.3")
                     else:
@@ -3145,8 +3145,8 @@ def chkDescription(self, varName):
 
                     elif len(area_types):
                         for area in area_types:
-                            if not area.decode('utf-8') in list(self.area_type_lh.list):
-                                self._add_error("Invalid area_type: {}".format(area.decode('utf-8')),
+                            if not area.tolist().decode('utf-8') in list(self.area_type_lh.list):
+                                self._add_error("Invalid area_type: {}".format(area.tolist().decode('utf-8')),
                                                 varName, code="3.3")
 
                     else:

test_files/.gitignore

@@ -0,0 +1,3 @@
+*.nc
+tests_output*
+cfcache-files-py3/

test_files/issue110.check

@@ -0,0 +1,32 @@
+CHECKING NetCDF FILE: issue110.nc
+=====================
+Using CF Checker Version 4.1.0
+Checking against CF Version CF-1.7
+Using Standard Name Table Version 79 (2022-03-19T15:25:54Z)
+Using Area Type Table Version 10 (23 June 2020)
+Using Standardized Region Name Table Version 4 (18 December 2018)
+
+
+------------------
+Checking variable: siconca
+------------------
+
+------------------
+Checking variable: time
+------------------
+
+------------------
+Checking variable: lat
+------------------
+
+------------------
+Checking variable: lon
+------------------
+
+------------------
+Checking variable: type
+------------------
+
+ERRORS detected: 0
+WARNINGS given: 0
+INFORMATION messages: 0

test_files/tests.sh

@@ -6,17 +6,21 @@
 outdir=tests_output.$$
 mkdir $outdir
 
-std_name_table=http://cfconventions.org/Data/cf-standard-names/current/src/cf-standard-name-table.xml
-area_table=http://cfconventions.org/Data/area-type-table/current/src/area-type-table.xml
+# Pin the tables, as the tests fail if they differ.
+# This can be unpinned in future MRs updating the tests.
+std_name_table=https://cfconventions.org/Data/cf-standard-names/79/src/cf-standard-name-table.xml
+area_table=https://cfconventions.org/Data/area-type-table/10/src/area-type-table.xml
 
-cfchecker="cfchecks"
+
+cfchecker=$(which cfchecks)
 
 failed=0
 
 echo "Unzipping input netcdf files..."
 gzip -d *.gz
 
-cache_opts="-x --cache_dir /home/ros/temp/cfcache-files-py3"
+mkdir -p cfcache-files-py3
+cache_opts="-x --cache_dir ./cfcache-files-py3"
 
 for file in `ls *.nc`
 do
@@ -37,7 +41,7 @@ do
     $cfchecker $cache_opts -s $std_name_table -v 1.0 $file > $outdir/$file.out 2>&1
   else
     # Run checker using the CF version specified in the conventions attribute of the file
-    $cfchecker $cache_opts -s $std_name_table -v auto $file > $outdir/$file.out 2>&1
+    $cfchecker $cache_opts -s $std_name_table -a $area_table -v auto $file > $outdir/$file.out 2>&1
   fi
 
   # Check the output against what is expected