Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macOS builds with travis #930

Open
wants to merge 79 commits into
base: master
Choose a base branch
from
Open

Conversation

stephengroat
Copy link
Contributor

@stephengroat stephengroat commented Jan 11, 2019

closes #438, closes #875, closes #912

still an issue with gcc tests on macos

https://travis-ci.org/cea-sec/miasm/jobs/478366262#L928

@stephengroat
Copy link
Contributor Author

needs to run on appveyor to check for windows issues

@stephengroat stephengroat changed the title Macos macOS builds with travis Jan 11, 2019
@stephengroat
Copy link
Contributor Author

@commial this works, but the gcc test cases seem to be failing (see https://travis-ci.org/cea-sec/miasm/jobs/479469186#L925)

do those have to be working for osx? if not, could you make a MIASM_TEST_EXTRA_ARG variable for https://github.com/cea-sec/miasm/pull/930/files#diff-354f30a63fb0907d4ad57269548329e3R33 so that we could limit to osx job to non gcc cases and get everything passing?

@commial
Copy link
Contributor

commial commented Jan 16, 2019

Not sure to understand what you're asking.
If you want to try without gcc, you just have to remove:
-o qemu -t python,llvm
-o gcc -t qemu,long

And replace -o long by -o long -t gcc. -o is whitelisting, -t is blacklisting.

Regarding the necessity of gcc on MacOS X, I'm not sure. If we have at least one of the fast jitter (either CC based or LLVM), it should be OK. Thoughts @serpilliere ?

Note: maybe it could work with Clang or specific options. For instance, on Windows, it is actually using cl with others flags. Options can be customized in JitCore_Gcc.add_block

@XVilka
Copy link
Contributor

XVilka commented Mar 5, 2020

  • Should be rebased I think
  • Travis now supports Windows too, so you might extend with it too.

@serpilliere
Copy link
Contributor

@XVilka : note that we already have windows regressions tests run on appveyor.
Do you propose removing appveyor in favor of travis?
Can you argu on this ?

@XVilka
Copy link
Contributor

XVilka commented Mar 5, 2020

No, I am not insisting. Missed the AppVeyor thing, sorry.

@serpilliere
Copy link
Contributor

No problem!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.