Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix typos in tokens #646

Merged
merged 2 commits into from
Sep 18, 2024
Merged

fix: Fix typos in tokens #646

merged 2 commits into from
Sep 18, 2024

Conversation

ethanWallace
Copy link
Collaborator

@ethanWallace ethanWallace commented Sep 18, 2024

Summary | Résumé

The gcds-nav-link has a typo when setting the font property (var(---gcds-nav-link-font)). It should be var(--gcds-nav-link-font).

@amazingphilippe
Copy link
Contributor

I was curious and did a search, there's one more triple dash in css code: https://github.com/search?q=repo%3Acds-snc%2Fgcds-components+---+language%3Acss&type=code

Copy link
Collaborator

@daine daine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ethanWallace ethanWallace changed the title fix: Fix typo in font token in gcds-nav-link fix: Fix typos in tokens Sep 18, 2024
@ethanWallace ethanWallace merged commit 4c8d850 into main Sep 18, 2024
3 checks passed
@ethanWallace ethanWallace deleted the fix/nav-link-font-token branch September 18, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants