fix: various small design bug fixes (#634)

* refactor: fix footer heading font * style: fix white border bug for contextual footer band * fix: remove bullet point from mobile nav-group * chore: update tokens package
cds-snc · Sep 12, 2024 · 8eefbe4 · 8eefbe4
1 parent 085d964
commit 8eefbe4
Show file tree

Hide file tree

Showing 4 changed files with 20 additions and 5 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/packages/web/package.json b/packages/web/package.json
@@ -45,7 +45,7 @@
     "@babel/core": "^7.20.12",
     "@babel/preset-env": "^7.20.2",
     "@babel/preset-typescript": "^7.21.0",
-    "@cdssnc/gcds-tokens": "^1.17.1",
+    "@cdssnc/gcds-tokens": "^1.18.1",
     "@fortawesome/fontawesome-free": "^6.3.0",
     "@stencil/angular-output-target": "file:../../utils/angular-output-target",
     "@stencil/postcss": "^2.1.0",

diff --git a/packages/web/src/components/gcds-footer/gcds-footer.css b/packages/web/src/components/gcds-footer/gcds-footer.css
@@ -65,6 +65,14 @@
         color: var(--gcds-footer-main-text);
       }
     }
+
+    h3 {
+      font: var(--gcds-footer-font-heading-desktop);
+
+      @media only screen and (width < 48em) {
+        font: var(--gcds-footer-font-heading-mobile);
+      }
+    }
   }
 }
 
@@ -75,6 +83,9 @@
     background-color: var(--gcds-footer-contextual-background);
     color: var(--gcds-footer-contextual-text);
     padding: var(--gcds-footer-contextual-padding);
+
+    /* Fix weird white border bug */
+    margin-block-end: -1px;
   }
 }
 

diff --git a/packages/web/src/components/gcds-nav-group/gcds-nav-group.css b/packages/web/src/components/gcds-nav-group/gcds-nav-group.css
@@ -35,6 +35,10 @@
     .gcds-nav-group__trigger-desc {
       display: none;
     }
+
+    ul {
+      list-style: none;
+    }
   }
 }