-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge Astropy Angle support to Master #83
Merge Astropy Angle support to Master #83
Conversation
a7a36d0
to
42c93ce
Compare
@@ -1,4 +1,4 @@ | |||
import A from "https://esm.sh/aladin-lite@3.3.3-beta"; | |||
import A from "https://esm.sh/aladin-lite@3.4.0-beta"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You might be able to remove the goToRaDec after initialization with this bump.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, this should be in the changelog and in the readme
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Despite the version change, the removing of gotoRaDec call at the initialization re-introduce the patched bug.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Too bad, thanks for testing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the correspondence table at the end of the README, could you add a line with unreleased || 3.4.0-beta
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is because when you instanciate aladin with:
let aladin = Aladin({target: '0 0', cooFrame: 'galactic', ...})
as there is no frame given with the target position string, it will take that position as what is given in the cooFrame.
@tboch - Should we consider that behaviour as okaish or target
should be always considered as given in ICRS frame ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the correspondence table at the end of the README, could you add a line with
unreleased || 3.4.0-beta
?
Done !
No description provided.