Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge global refactoring to Master #82

Merged
merged 31 commits into from
May 7, 2024

Conversation

Xen0Xys
Copy link
Contributor

@Xen0Xys Xen0Xys commented Apr 23, 2024

The objective of this PR is to suggest a way to refactor the project and mainly the Javascript part with some improvements :

@Xen0Xys Xen0Xys changed the title Merge global refactoring to master Merge global refactoring to Master Apr 23, 2024
@ManonMarchand
Copy link
Member

Maybe we could run the tests for the oldest and newest python versions that are supported ? (3.8 and 3.12)

pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
src/ipyaladin/__init__.py Outdated Show resolved Hide resolved
@Xen0Xys Xen0Xys force-pushed the refactor/global-refactoring branch from 8fdb468 to 83cf62c Compare April 29, 2024 11:18
@Xen0Xys Xen0Xys force-pushed the refactor/global-refactoring branch from 83cf62c to 3fee59c Compare April 29, 2024 13:53
@ManonMarchand
Copy link
Member

Fixes #77

@Xen0Xys Xen0Xys force-pushed the refactor/global-refactoring branch 4 times, most recently from d8a0fa3 to 8bc495c Compare April 30, 2024 12:24
@ManonMarchand ManonMarchand marked this pull request as ready for review April 30, 2024 12:59
@Xen0Xys Xen0Xys force-pushed the refactor/global-refactoring branch from 8bc495c to 0e3a91b Compare April 30, 2024 14:20
@Xen0Xys Xen0Xys force-pushed the refactor/global-refactoring branch from 0e3a91b to 40c0823 Compare May 2, 2024 06:59
Copy link
Collaborator

@bmatthieu3 bmatthieu3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just little comments on the JS part. Otherwise it is good to merge from my point of view.

js/imports.js Outdated Show resolved Hide resolved
js/models/message_handler.js Outdated Show resolved Hide resolved
js/models/message_handler.js Outdated Show resolved Hide resolved
@Xen0Xys Xen0Xys requested a review from bmatthieu3 May 2, 2024 07:43
@Xen0Xys
Copy link
Contributor Author

Xen0Xys commented May 3, 2024

Do not merge until the recursion bug isn't fixed !

@ManonMarchand ManonMarchand marked this pull request as draft May 3, 2024 13:12
@Xen0Xys Xen0Xys force-pushed the refactor/global-refactoring branch 2 times, most recently from 5ea3dd4 to 1060451 Compare May 6, 2024 12:24
@Xen0Xys Xen0Xys marked this pull request as ready for review May 6, 2024 14:10
@Xen0Xys Xen0Xys requested a review from ManonMarchand May 6, 2024 14:10
.github/workflows/python-tests.yml Outdated Show resolved Hide resolved
src/ipyaladin/aladin.py Show resolved Hide resolved
src/ipyaladin/aladin.py Outdated Show resolved Hide resolved
src/ipyaladin/aladin.py Outdated Show resolved Hide resolved
@Xen0Xys Xen0Xys force-pushed the refactor/global-refactoring branch from 1060451 to 8c1bdce Compare May 7, 2024 06:27
@ManonMarchand ManonMarchand merged commit 39415a9 into cds-astro:master May 7, 2024
3 checks passed
@Xen0Xys Xen0Xys deleted the refactor/global-refactoring branch May 7, 2024 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow the list of keyword options (CatalogOptions, HiPSOptions, MOCOptions, ...) passed to be case insensitive
3 participants