-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge global refactoring to Master #82
Merged
ManonMarchand
merged 31 commits into
cds-astro:master
from
Xen0Xys:refactor/global-refactoring
May 7, 2024
Merged
Merge global refactoring to Master #82
ManonMarchand
merged 31 commits into
cds-astro:master
from
Xen0Xys:refactor/global-refactoring
May 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xen0Xys
changed the title
Merge global refactoring to master
Merge global refactoring to Master
Apr 23, 2024
Maybe we could run the tests for the oldest and newest python versions that are supported ? (3.8 and 3.12) |
Xen0Xys
force-pushed
the
refactor/global-refactoring
branch
from
April 29, 2024 11:18
8fdb468
to
83cf62c
Compare
…_moc and add_overlay_from_stcs
Xen0Xys
force-pushed
the
refactor/global-refactoring
branch
from
April 29, 2024 13:53
83cf62c
to
3fee59c
Compare
Fixes #77 |
Xen0Xys
force-pushed
the
refactor/global-refactoring
branch
4 times, most recently
from
April 30, 2024 12:24
d8a0fa3
to
8bc495c
Compare
…f the function behavior Deprecate add_listener and add a warning from a "private" parameter
Xen0Xys
force-pushed
the
refactor/global-refactoring
branch
from
April 30, 2024 14:20
8bc495c
to
0e3a91b
Compare
Xen0Xys
force-pushed
the
refactor/global-refactoring
branch
from
May 2, 2024 06:59
0e3a91b
to
40c0823
Compare
bmatthieu3
requested changes
May 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just little comments on the JS part. Otherwise it is good to merge from my point of view.
Do not merge until the recursion bug isn't fixed ! |
Xen0Xys
force-pushed
the
refactor/global-refactoring
branch
2 times, most recently
from
May 6, 2024 12:24
5ea3dd4
to
1060451
Compare
Xen0Xys
force-pushed
the
refactor/global-refactoring
branch
from
May 7, 2024 06:27
1060451
to
8c1bdce
Compare
ManonMarchand
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The objective of this PR is to suggest a way to refactor the project and mainly the Javascript part with some improvements :
pyproject.toml