Skip to content

Commit

Permalink
maint: prepare release 0.4.0
Browse files Browse the repository at this point in the history
fix: A.line was removed from public AL API in favor of A.vector
  • Loading branch information
ManonMarchand committed Jul 16, 2024
1 parent e99e599 commit 2454c0e
Show file tree
Hide file tree
Showing 6 changed files with 45 additions and 27 deletions.
8 changes: 7 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

## [0.4.0]

### Added

- attribute `__aladin_lite_version__` added to point to the corresponding Aladin Lite released version
Expand All @@ -27,15 +29,19 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

- `clicked_object` was not properly updated after a click
- Fix asynchronous update for the `target` property (#80)
- some options were not accepted in snake_case anymore in `add_moc` and in `add_catalog_from_url` (#82)

### Changed

- Change the jslink target trait from `target` to `shared_target` (#80)
- Change the jslink fov trait from `fov` to `shared_fov` (#83)
- Deprecate the `add_listener` method for a preferred use of `set_listener` method (#82)
- Upgrade Aladin Lite version to 3.4.1-beta (#88)
- Add support for list of strings in `add_overlay_from_stcs` (#88)

### Deprecated

- Deprecate `add_overlay_from_stcs` in favor of `add_graphic_overlay_from_stcs` (#88)
- Deprecate the `add_listener` method for a preferred use of `set_listener` method (#82)

## [0.3.0]

Expand Down
12 changes: 6 additions & 6 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -56,21 +56,21 @@ Ipyaladin brings [Aladin Lite](https://github.com/cds-astro/aladin-lite) into no

Correspondence table between ipyaladin versions and Aladin Lite versions:

| ipyaladin | Aladin-Lite |
| ---------- | ----------- |
| 0.3.0 | 3.3.3-dev |
| unreleased | 3.4.1-beta |
| ipyaladin | Aladin-Lite |
| --------- | ----------- |
| 0.3.0 | 3.3.3-dev |
| 0.4.0 | 3.4.4-beta |

> [!TIP]
> This can always be read like so
>
> ```python
> from ipyaladin import __version__, __aladin_lite_version__
> print("version:", __version__, "running aladin lite:", __aladin_lite_version__)
> print("version:", __version__, "running Aladin Lite:", __aladin_lite_version__)
> ```
>
> ```
> version: unreleased running aladin lite: 3.4.1-beta
> version: 0.4.0 running Aladin Lite: 3.4.4-beta
> ```
## Acknowledging ipyaladin
Expand Down
42 changes: 26 additions & 16 deletions examples/2_Base_Commands.ipynb
Original file line number Diff line number Diff line change
Expand Up @@ -72,11 +72,13 @@
]
},
{
"metadata": {},
"cell_type": "code",
"outputs": [],
"execution_count": null,
"source": "aladin.target"
"metadata": {},
"outputs": [],
"source": [
"aladin.target"
]
},
{
"cell_type": "code",
Expand Down Expand Up @@ -118,7 +120,7 @@
},
"outputs": [],
"source": [
"aladin.coo_frame = \"J2000d\""
"aladin.coo_frame = \"ICRSd\" # ICRS, and angles expressed in degrees"
]
},
{
Expand All @@ -131,30 +133,38 @@
]
},
{
"metadata": {},
"cell_type": "markdown",
"source": "Some commands can be used with astropy objects"
"metadata": {},
"source": [
"Some commands can be used with astropy objects"
]
},
{
"metadata": {},
"cell_type": "code",
"outputs": [],
"execution_count": null,
"source": "from astropy.coordinates import Angle, SkyCoord"
"metadata": {},
"outputs": [],
"source": [
"from astropy.coordinates import Angle, SkyCoord"
]
},
{
"metadata": {},
"cell_type": "code",
"outputs": [],
"execution_count": null,
"source": "aladin.target = SkyCoord(\"12h00m00s\", \"-30d00m00s\", frame=\"icrs\")"
"metadata": {},
"outputs": [],
"source": [
"aladin.target = SkyCoord(\"12h00m00s\", \"-30d00m00s\", frame=\"icrs\")"
]
},
{
"metadata": {},
"cell_type": "code",
"outputs": [],
"execution_count": null,
"source": "aladin.fov = Angle(5, \"deg\")"
"metadata": {},
"outputs": [],
"source": [
"aladin.fov = Angle(5, \"deg\")"
]
}
],
"metadata": {
Expand All @@ -173,7 +183,7 @@
"name": "python",
"nbconvert_exporter": "python",
"pygments_lexer": "ipython3",
"version": "3.11.3"
"version": "3.11.8"
},
"vscode": {
"interpreter": {
Expand Down
2 changes: 1 addition & 1 deletion js/aladin_lite.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
import A from "https://esm.sh/[email protected].1-beta";
import A from "https://esm.sh/[email protected].4-beta";

export default A;
4 changes: 3 additions & 1 deletion js/models/message_handler.js
Original file line number Diff line number Diff line change
Expand Up @@ -63,8 +63,10 @@ export default class MessageHandler {
);
break;
case "line":
// remove default lineWidth when we switch to AL > 3.4.4
region.options.lineWidth = region.options.lineWidth || 3;
overlay.add(
A.line(
A.vector(
infos.ra1,
infos.dec1,
infos.ra2,
Expand Down
4 changes: 2 additions & 2 deletions src/ipyaladin/__about__.py
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
__version__ = "0.4.0-beta"
__aladin_lite_version__ = "3.4.1-beta"
__version__ = "0.4.0"
__aladin_lite_version__ = "3.4.4-beta"

0 comments on commit 2454c0e

Please sign in to comment.