Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helm codegen additionalValues flattening does not handle null props #2139

Open
yuriy-yarosh opened this issue Jul 11, 2024 · 0 comments · May be fixed by cdk8s-team/cdk8s-cli#2495
Open

helm codegen additionalValues flattening does not handle null props #2139

yuriy-yarosh opened this issue Jul 11, 2024 · 0 comments · May be fixed by cdk8s-team/cdk8s-cli#2495
Labels
bug Something isn't working @component/cdk8s-cli Issue related to cdk8s-cli effort/small 1 day tops priority/p2 Dependent on community feedback. PR's are welcome :)

Comments

@yuriy-yarosh
Copy link

Description of the bug:

Importing goldilocks chart result in a destructuring error.

image

image

Props can be null occasionally.

image

Reproduction Steps:

Import goldilocks helm chart, pass values.

Error Log:

Codegen should be able to handle null props

Environment:

  • Framework Version: "cdk8s-cli": "^2.198.168",
  • OS: Arch

Other

Fixable with a small codegen change over here

code.line('const { additionalValues, ...valuesWithoutAdditionalValues } = props;');

Should be

code.line('const { additionalValues, ...valuesWithoutAdditionalValues } = props || {};');

the way I see it.

Needs confirmation.


This is 🐛 Bug Report

@yuriy-yarosh yuriy-yarosh added bug Something isn't working needs-triage Priority and effort undetermined yet labels Jul 11, 2024
@iliapolo iliapolo added priority/p2 Dependent on community feedback. PR's are welcome :) effort/small 1 day tops and removed needs-triage Priority and effort undetermined yet labels Jul 28, 2024
@iliapolo iliapolo transferred this issue from cdk8s-team/cdk8s-cli Sep 19, 2024
@iliapolo iliapolo added the @component/cdk8s-cli Issue related to cdk8s-cli label Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working @component/cdk8s-cli Issue related to cdk8s-cli effort/small 1 day tops priority/p2 Dependent on community feedback. PR's are welcome :)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants