Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(helm): destructuring error when import chart with null props #2495

Open
wants to merge 3 commits into
base: 2.x
Choose a base branch
from

Conversation

yuriy-yarosh
Copy link

Fixes cdk8s-team/cdk8s#2139 destructuring error.

Signed-off-by: Yuriy Yarosh <[email protected]>
@yuriy-yarosh yuriy-yarosh changed the title Fixes #2494 fix: fixes #2494 Jul 11, 2024
@iliapolo iliapolo changed the title fix: fixes #2494 fix(helm): destructuring error when import chart with null props Jul 28, 2024
Copy link
Member

@iliapolo iliapolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yuriy-yarosh could you also add a test for this scenario? best would be to just add the chart you identifier the issue with here:

describe.each([
'helm:https://charts.bitnami.com/bitnami/[email protected]', // Contains schema and dependencies
'helm:https://kubernetes.github.io/ingress-nginx/[email protected]', // Does not contain schema
'helm:https://lacework.github.io/helm-charts/[email protected]',
'helm:oci://registry-1.docker.io/bitnamicharts/[email protected]',
'minio:=helm:https://operator.min.io/[email protected]',
'helm:https://grafana.github.io/helm-charts/[email protected]',
])('importing helm chart %s', (testChartUrl) => {

@iliapolo iliapolo added the response-requested Awaiting response from author label Sep 10, 2024
@iliapolo
Copy link
Member

@yuriy-yarosh are you still available to see this through?

@github-actions github-actions bot removed the response-requested Awaiting response from author label Sep 10, 2024
@iliapolo iliapolo added the response-requested Awaiting response from author label Sep 10, 2024
@yuriy-yarosh
Copy link
Author

@iliapolo being conscripted, so things are a bit all over the place.
I'll take a look today.

@github-actions github-actions bot removed the response-requested Awaiting response from author label Sep 11, 2024
@iliapolo iliapolo added the response-requested Awaiting response from author label Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
response-requested Awaiting response from author
Projects
None yet
Development

Successfully merging this pull request may close these issues.

helm codegen additionalValues flattening does not handle null props
2 participants