Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(import): csharp support #2519

Open
wants to merge 3 commits into
base: 2.x
Choose a base branch
from
Open

feat(import): csharp support #2519

wants to merge 3 commits into from

Conversation

ScottKane
Copy link

Added support for calling jsii-srcmak with csharp/dotnet from cdk8s import (REGEX applied to convert names to PascalCase where possible)

@iliapolo iliapolo changed the title feat(src/import): Add support for dotnet to cdk8s import. feat(import): Add support for dotnet to cdk8s import. Jul 28, 2024
@iliapolo
Copy link
Member

Looks like a we have another PR for this exact feature: #2520.

@ScottKane How do you feel about reaching out to the author and deciding on the one PR we should be merging? :)

Copy link
Member

@iliapolo iliapolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iliapolo iliapolo changed the title feat(import): Add support for dotnet to cdk8s import. feat(import): csharp support Sep 10, 2024
@iliapolo
Copy link
Member

Ah ok this is just adding csharp to import and not as an init template. Still, we need a test for it then because its not covered by init tests.

@iliapolo iliapolo added the response-requested Awaiting response from author label Sep 10, 2024
@iliapolo
Copy link
Member

@ScottKane see #2520 (comment)

@github-actions github-actions bot removed the response-requested Awaiting response from author label Sep 10, 2024
@iliapolo iliapolo added the response-requested Awaiting response from author label Sep 11, 2024
@ScottKane
Copy link
Author

@iliapolo Integration test added and template added. I have also renamed everything to use the csharp convention

@github-actions github-actions bot removed the response-requested Awaiting response from author label Sep 19, 2024
@ScottKane
Copy link
Author

also jsii seems to hard code target framework to netcoreapp3.1 which isn't ideal but will solve that in the future

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants