-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(import): csharp support #2519
base: 2.x
Are you sure you want to change the base?
Conversation
Signed-off-by: Scott Kane <[email protected]>
Looks like a we have another PR for this exact feature: #2520. @ScottKane How do you feel about reaching out to the author and deciding on the one PR we should be merging? :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing integ test. See https://github.com/cdk8s-team/cdk8s-cli/blob/2.x/test/integ/init.test.ts
Ah ok this is just adding csharp to import and not as an init template. Still, we need a test for it then because its not covered by init tests. |
Signed-off-by: Scott Kane <[email protected]>
@iliapolo Integration test added and template added. I have also renamed everything to use the |
also |
Signed-off-by: ScottKane <[email protected]>
Added support for calling
jsii-srcmak
withcsharp/dotnet
fromcdk8s import
(REGEX applied to convert names to PascalCase where possible)