Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: respect hyphens in helm chart names #1666

Draft
wants to merge 3 commits into
base: 2.x
Choose a base branch
from
Draft

fix: respect hyphens in helm chart names #1666

wants to merge 3 commits into from

Commits on Nov 21, 2023

  1. Respect hyphens in helm chart names 

    From `json2jsii` 0.4.0 onwards, type name sanitization works correctly with kebab case, i.e. it no longer ignores
hyphens, so that names like `ingress-nginx`, which previously have been previously converted to `Ingressnginx`, now get
converted to `IngressNginx`, which is the expected behaviour for kebab case to pascal case conversion. However,
`cdk8s-cli`'s helm import has been additionally sanitizing hyphens in chart names, even though hyphens are valid
characters in chart names, so that the change in `json2jsii` had no effect. This patch simplifies the helm importer's
sanitization routine to not remove hyphens anymore, resulting in more correct class names.

Signed-off-by: Nikolai Prokoschenko <[email protected]>
    @rassie
    rassie committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    6f782a4 View commit details
    Browse the repository at this point in the history

Commits on Dec 20, 2023

  1. Merge branch '2.x' into handle-kebab-case

    @rassie
    rassie committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    d7398ab View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2024

  1. Merge branch '2.x' into handle-kebab-case

    @iliapolo
    iliapolo committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    28d6390 View commit details
    Browse the repository at this point in the history