Fix Portuguese translation issues #509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
*This commit addresses several translation issues in FastFlix's Portuguese language support. *The changes include fixing incorrect translations, adding missing translations, modificando e adaptando termos com nuance ou que dependem do contexto and ensuring consistency throughout the user interface. The modifications were made to the `fastflix/data/languages.yaml` file and the `fastflix/widgets/settings.py` file.
*Parameters and encoder keywords kept matching original english string references, only their descriptions were translated. *Fix to a specific term "comando pós-conclusão".
Some words were changed for a more accurate meaning
mindwired
changed the title
|
Thank you so much for these updates and pointing out what is still missing! Some of those are harder to fix than others, but will ttry to take on the easiest ones with this release. Also will have to keep the name just "Portuguese" due to internal mappings. |
Merged
cdgriffith
added a commit
that referenced
this pull request
Aug 26, 2023
* Fixing #503 missing CRF mode for SVT-AV1 (thanks to ignace72) * Fixing #506 excessive amounts of RAM used and not cleared - partially mitigated (thanks to 19Battlestar65) * Fixing #509 Portuguese translations (thanks to Felipe Augusto Arantes de Souza) * Fixing #513 Profile configuration issues, including with load directory (thanks to Nikita S.) * Fixing #516 Performance improvements due to constant stream reads (thanks to William Barath) --------- Co-authored-by: Felipe Augusto Arantes de Souza <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request aim to fix several translation issues in GUI Portuguese language support, addressing the translation issues I mentioned here: #507
Changes Made:
Known Issues:
Despite the progress made in the translation, as mentioned in the issue ticket, there are yet a few outstanding issues require attention, since they affect other languages as well:
Profiles Menu > Current Profile Settings:
All the key fields from this window does exist in the YAML file and I have already translated each of them, but the fields aren't showing the correct mapped strings after changing the GUI language in the settings menu like the rest of the GUI.
Help > About:
The following strings also are not mapped in the YAML file: "Conversion suites", "Encoders", "Supporting libraries", "Packaged with".
In the following image, there are in green 2 examples of correctly mapped strings in comparison.
Main Page > Advanced > Frame Rate section:
The "vsync" string is entirely in lowercase. I refrained from fixing this since the YAML file resolves this keyword in all languages also to 'vsync' equally and in lowercase. I think that modifying it could potentially break other parts of the application that rely on the mapping for this specyfic keyword. If it isn't the case, I would rename it to appear as 'VSync' in the GUI.
Main Page > Advanced > VBV section:
The VBV section's title mapping is split into the "Video Buffering" and "Verifier" mappings in the YAML file resulting in "Video Buffering Verifier (VBV)" in the GUI, also I have not found the last part "(VBV)" there...
Due to the fragmented mapping, it became challenging to provide an accurate translation for this field, because in pt-BR it should be "Verificador de Buffer de Vídeo (VBV)", but I have no way to put in correct order since the YAML is probably joined inside the code. The splitted translation in the YAML results in an "understandable", but still strange "Buffer de Vídeo Verificador (VBV)" pt-BR text to a native speaker, I kept this way for now but I'm documenting the problem so that in the future It could be useful to make optimizations in the languages string mapping.
Main Page > Advanced > VBV section:
The text at the end of this section is not mapped in the YAML file.
When mapped, the pt-BR translation should be "Ambos precisam estar preenchidos para serem habilitados".
Main Page > Encoding Queue > Priority:
This dropdown's values are not mapped in the YAML file.
Main Page > Encoding Queue > After Conversion:
This dropdown's values are not mapped in the YAML file.
Details
For more detailed description of these known issues and prints, please refer to #507
Thank you!