Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CDAP-21059] provide actional messages for known http error codes #15711

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,163 @@
/*
* Copyright © 2024 Cask Data, Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License"); you may not
* use this file except in compliance with the License. You may obtain a copy of
* the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
* WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
* License for the specific language governing permissions and limitations under
* the License.
*/

package io.cdap.cdap.api.exception;

import java.net.HttpURLConnection;
import java.util.Objects;
import javax.annotation.Nullable;

/**
* Utility class for handling errors and providing corrective actions.
* <p>
* This class provides a method to retrieve corrective actions and error types
* based on HTTP status codes. It can be used to provide helpful error messages
* to users.
* </p>
*/
public final class ErrorUtils {

/**
* Pair class to hold corrective action and error type.
*/
public static class ActionErrorPair {
private final String correctiveAction;
private final ErrorType errorType;

ActionErrorPair(String correctiveAction, ErrorType errorType) {
this.correctiveAction = correctiveAction;
this.errorType = errorType;
}

@Override
public boolean equals(Object o) {
if (this == o) {
return true;
}
if (o == null || getClass() != o.getClass()) {
return false;
}
ActionErrorPair pair = (ActionErrorPair) o;
return Objects.equals(correctiveAction, pair.correctiveAction)
&& Objects.equals(errorType, pair.errorType);
}

@Override
public int hashCode() {
return Objects.hash(correctiveAction, errorType);
}

/**
* Returns the corrective action for the error.
*
* @return The corrective action as a {@link String}.
*/
public String getCorrectiveAction() {
return correctiveAction;
}

/**
* Returns the error type for the error.
*
* @return The error type as a {@link ErrorType}.
*/
public ErrorType getErrorType() {
return errorType;
}
}

/**
* Returns a {@link ActionErrorPair} object containing corrective action and error type based
* on the given status code.
*
* @param statusCode The HTTP status code.
* @return A ActionErrorPair object with corrective action and error type.
*/
public static ActionErrorPair getActionErrorByStatusCode(Integer statusCode) {
switch (statusCode) {
case HttpURLConnection.HTTP_BAD_REQUEST:
return new ActionErrorPair("Bad Request. Please check the request parameters and syntax.",
ErrorType.USER);
case HttpURLConnection.HTTP_UNAUTHORIZED:
return new ActionErrorPair("Unauthorized. Please ensure valid authentication "
+ "credentials are provided.", ErrorType.USER);
case HttpURLConnection.HTTP_FORBIDDEN:
return new ActionErrorPair("Forbidden. Please check you have permission to "
+ "access this resource.", ErrorType.USER);
case HttpURLConnection.HTTP_NOT_FOUND:
return new ActionErrorPair("Not Found. Please verify the URL or resource you're "
+ "trying to access.", ErrorType.USER);
case HttpURLConnection.HTTP_BAD_METHOD:
return new ActionErrorPair("Method Not Allowed. Please check if the HTTP method "
+ "(GET, POST, etc.) is correct.", ErrorType.USER);
case HttpURLConnection.HTTP_CONFLICT:
return new ActionErrorPair("Conflict. Please resolve any conflicts, such as resource "
+ "versioning issues.", ErrorType.USER);
case HttpURLConnection.HTTP_PRECON_FAILED:
return new ActionErrorPair("Precondition Failed. Please check the request headers "
+ "to ensure the conditions are accurate and valid.", ErrorType.USER);
case HttpURLConnection.HTTP_CLIENT_TIMEOUT:
return new ActionErrorPair("Request timed out. The server took too long to respond, "
+ "please try again or check your connection.", ErrorType.USER);
case 429:
return new ActionErrorPair("Too Many Requests: Slow down your requests and "
+ "please try again later.", ErrorType.USER);
case HttpURLConnection.HTTP_INTERNAL_ERROR:
return new ActionErrorPair("Internal Server Error. The service is unavailable, "
+ "try again later.", ErrorType.SYSTEM);
case HttpURLConnection.HTTP_UNAVAILABLE:
return new ActionErrorPair("Service Unavailable. The service is unavailable, "
+ "try again later.", ErrorType.SYSTEM);
case HttpURLConnection.HTTP_BAD_GATEWAY:
return new ActionErrorPair("Bad Gateway. Please ensure there are no network connectivity "
+ "issues between the proxy/gateway server and the upstream server or try again later.",
ErrorType.SYSTEM);
default:
return new ActionErrorPair(String.format("Request failed with error code: %s", statusCode),
ErrorType.UNKNOWN);
}
}

/**
* Get a ProgramFailureException with the given error information.
*
* @param errorCategory The category of the error.
* @param errorReason The reason for the error.
* @param errorMessage The error message.
* @param errorType The type of error.
* @param dependency The bool representing whether the error is coming from a dependent service.
* @param cause The cause of the error.
* @return A ProgramFailureException with the given error information.
*/
public static ProgramFailureException getProgramFailureException(ErrorCategory errorCategory,
String errorReason, String errorMessage, ErrorType errorType, boolean dependency,
@Nullable Throwable cause) {

ProgramFailureException.Builder builder = new ProgramFailureException.Builder();

if (cause != null) {
builder = builder.withCause(cause);
}

return builder
.withErrorCategory(errorCategory)
.withErrorReason(errorReason)
.withErrorMessage(errorMessage)
.withErrorType(errorType)
.withDependency(dependency)
.build();
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,12 @@ public Builder withCause(Throwable cause) {
return this;
}

/**
* Sets the dependency flag for the ProgramFailureException.
*
* @param dependency True if the error is from a dependent service, false otherwise.
* @return The current Builder instance.
*/
public Builder withDependency(boolean dependency) {
this.dependency = dependency;
return this;
Expand Down
Loading