[CDAP-20479] Add sidecar metadata service for credential provisioning #15260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itsankit-google
force-pushed
the
CDAP-20749
branch
5 times, most recently
from
e51b676
to
ef207bd
Compare
dli357
reviewed
Aug 2, 2023
...c/src/main/java/io/cdap/cdap/internal/app/worker/sidecar/GCPMetadataHttpHandlerInternal.java
Outdated
Show resolved
Hide resolved
...c/src/main/java/io/cdap/cdap/internal/app/worker/sidecar/GCPMetadataHttpHandlerInternal.java
Outdated
Show resolved
Hide resolved
...c/src/main/java/io/cdap/cdap/internal/app/worker/sidecar/GCPMetadataHttpHandlerInternal.java
Outdated
Show resolved
Hide resolved
...c/src/main/java/io/cdap/cdap/internal/app/worker/sidecar/GCPMetadataHttpHandlerInternal.java
Outdated
Show resolved
Hide resolved
cdap-kubernetes/src/main/java/io/cdap/cdap/k8s/runtime/KubeTwillPreparer.java
Show resolved
Hide resolved
itsankit-google
force-pushed
the
CDAP-20749
branch
5 times, most recently
from
8c24e63
to
d42138c
Compare
dli357
reviewed
Aug 8, 2023
...c/src/main/java/io/cdap/cdap/internal/app/worker/sidecar/GcpMetadataHttpHandlerInternal.java
Outdated
Show resolved
Hide resolved
itsankit-google
force-pushed
the
CDAP-20749
branch
2 times, most recently
from
7c6e008
to
007a5d8
Compare
itsankit-google
force-pushed
the
CDAP-20749
branch
2 times, most recently
from
991f949
to
34b4379
Compare
dli357
reviewed
Aug 9, 2023
dli357
approved these changes
Aug 9, 2023
itsankit-google
force-pushed
the
CDAP-20749
branch
from
34b4379
to
23ea6e8
Compare
itsankit-google
added
the
credential_provider
itsankit-google
added
namespaced_service_accounts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: CDAP-20749
This PR does the following:
GCPMetadataHttpHandlerInternalin artifact localizer service in task worker and preview runners.GCPMetadataTaskContextclass to provide credentials to pass along with the call to the Credential Provider API.GCE_METADATA_HOSTenvironment variable intaskworkertwillrunnableandpreviewrunnertwillrunnablecontainers.GCPMetadataHttpHandlerInternal.