-
Notifications
You must be signed in to change notification settings - Fork 340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CDAP-20629] Create CredentialProvider API and SPI #15230
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dli357
added
build
Triggers github actions build
6.10
credential_provider
Label for tracking the credential provider feature.
labels
Jul 12, 2023
dli357
added
build
Triggers github actions build
and removed
build
Triggers github actions build
labels
Jul 12, 2023
dli357
force-pushed
the
feature/CDAP-20629-api
branch
2 times, most recently
from
July 12, 2023 21:07
241f9ae
to
63dc7b3
Compare
rmstar
reviewed
Jul 12, 2023
...-fabric/src/main/java/io/cdap/cdap/internal/credential/DefaultCredentialProviderService.java
Outdated
Show resolved
Hide resolved
rmstar
reviewed
Jul 12, 2023
...ic/src/main/java/io/cdap/cdap/internal/credential/handler/CredentialProviderHttpHandler.java
Show resolved
Hide resolved
rmstar
reviewed
Jul 13, 2023
cdap-api/src/main/java/io/cdap/cdap/api/security/credential/NotFoundException.java
Outdated
Show resolved
Hide resolved
rmstar
reviewed
Jul 13, 2023
cdap-api/src/main/java/io/cdap/cdap/api/security/credential/ProvisionedCredential.java
Outdated
Show resolved
Hide resolved
albertshau
reviewed
Jul 13, 2023
cdap-api/src/main/java/io/cdap/cdap/api/security/credential/ProvisionedCredential.java
Outdated
Show resolved
Hide resolved
cdap-app-fabric/src/main/java/io/cdap/cdap/internal/credential/CredentialProviderProvider.java
Outdated
Show resolved
Hide resolved
cdap-api/src/main/java/io/cdap/cdap/api/security/credential/CredentialProvider.java
Outdated
Show resolved
Hide resolved
cdap-security-spi/src/main/java/io/cdap/cdap/security/spi/credential/CredentialProvider.java
Outdated
Show resolved
Hide resolved
...curity-spi/src/main/java/io/cdap/cdap/security/spi/credential/CredentialProviderContext.java
Outdated
Show resolved
Hide resolved
dli357
force-pushed
the
feature/CDAP-20629-api
branch
5 times, most recently
from
July 18, 2023 23:03
26949c9
to
e3af6c7
Compare
albertshau
approved these changes
Jul 18, 2023
rmstar
approved these changes
Jul 19, 2023
dli357
force-pushed
the
feature/CDAP-20629-api
branch
from
July 19, 2023 17:27
073a2ba
to
7882f8c
Compare
…on handler methods, and add profile manager validation [CDAP-20629] Fix checkstyle warnings and reformat files [CDAP-20629] Refactor various ZK to lowercase Zk to comply with checkstyle [CDAP-20629] Refactor JVMResource, JMXMetricsCollector, and JMXMetricsCollectorFactory to lowercase Jvm and Jmx [CDAP-20629] Suppress warnings for SSL and HBase due to refactoring risk [CDAP-20629] Address comments [CDAP-20629] Moved CredentialProvider API classes to cdap-proto
dli357
force-pushed
the
feature/CDAP-20629-api
branch
from
July 19, 2023 23:16
7882f8c
to
8920564
Compare
itsankit-google
added
the
namespaced_service_accounts
Label for tracking namespaced service accounts feature
label
Oct 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
6.10
build
Triggers github actions build
credential_provider
Label for tracking the credential provider feature.
namespaced_service_accounts
Label for tracking namespaced service accounts feature
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does the following:
CredentialProvider
SPI to be implemented by extensionsCredentialProvider
API to be used by apps and plugins (not to be confused with the SPI)CredentialProviderService
which extends bothService
and APICredentialProvider
with a default implementationprovision
andvalidateIdentity
HTTP handlers to call theCredentialProviderService
CredentialIdentity
to thecdap-api
package so it's usable by the APICredentialProvider