Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CDAP-20629] Create CredentialProvider API and SPI #15230

Merged
merged 1 commit into from
Jul 20, 2023
Merged

[CDAP-20629] Create CredentialProvider API and SPI #15230

merged 1 commit into from
Jul 20, 2023

Conversation

dli357
Copy link
Contributor

@dli357 dli357 commented Jul 12, 2023

This PR does the following:

  • Creates a CredentialProvider SPI to be implemented by extensions
  • Creates a CredentialProvider API to be used by apps and plugins (not to be confused with the SPI)
  • Creates a CredentialProviderService which extends both Service and API CredentialProvider with a default implementation
  • Implements the provision and validateIdentity HTTP handlers to call the CredentialProviderService
  • Refactors CredentialIdentity to the cdap-api package so it's usable by the API CredentialProvider
  • Adds unit tests

@dli357 dli357 self-assigned this Jul 12, 2023
@dli357 dli357 added build Triggers github actions build 6.10 credential_provider Label for tracking the credential provider feature. labels Jul 12, 2023
@dli357 dli357 added build Triggers github actions build and removed build Triggers github actions build labels Jul 12, 2023
@dli357 dli357 force-pushed the feature/CDAP-20629-api branch 2 times, most recently from 241f9ae to 63dc7b3 Compare July 12, 2023 21:07
@dli357 dli357 force-pushed the feature/CDAP-20629-api branch 5 times, most recently from 26949c9 to e3af6c7 Compare July 18, 2023 23:03
@dli357
[CDAP-20629] Create CredentialProvider API and SPI, implement provisi…
8920564 
…on handler methods, and add profile manager validation

[CDAP-20629] Fix checkstyle warnings and reformat files

[CDAP-20629] Refactor various ZK to lowercase Zk to comply with checkstyle

[CDAP-20629] Refactor JVMResource, JMXMetricsCollector, and JMXMetricsCollectorFactory to lowercase Jvm and Jmx

[CDAP-20629] Suppress warnings for SSL and HBase due to refactoring risk

[CDAP-20629] Address comments

[CDAP-20629] Moved CredentialProvider API classes to cdap-proto
@dli357 dli357 merged commit 96b82f0 into develop Jul 20, 2023
5 checks passed
@dli357 dli357 deleted the feature/CDAP-20629-api branch July 20, 2023 06:33
@itsankit-google itsankit-google added the namespaced_service_accounts Label for tracking namespaced service accounts feature label Oct 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmstar rmstar rmstar approved these changes

@albertshau albertshau albertshau approved these changes

@itsankit-google itsankit-google Awaiting requested review from itsankit-google

Assignees

@dli357 dli357

Labels
6.10 build Triggers github actions build credential_provider Label for tracking the credential provider feature. namespaced_service_accounts Label for tracking namespaced service accounts feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dli357 @rmstar @albertshau @itsankit-google