Added toString to Subscribers

cdapio · Jul 25, 2023 · 1747f7e · 1747f7e
1 parent 1c0407e
commit 1747f7e
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 2 deletions.
diff --git a/cdap-app-fabric/src/main/java/io/cdap/cdap/internal/events/EventSubscriber.java b/cdap-app-fabric/src/main/java/io/cdap/cdap/internal/events/EventSubscriber.java
@@ -28,4 +28,8 @@ public abstract class EventSubscriber extends AbstractScheduledService {
    * Initialize this handler.
    */
   public abstract void initialize();
+
+  public String toString() {
+    return this.getClass().getSimpleName();
+  }
 }
diff --git a/cdap-app-fabric/src/main/java/io/cdap/cdap/internal/events/EventSubscriberManager.java b/cdap-app-fabric/src/main/java/io/cdap/cdap/internal/events/EventSubscriberManager.java
@@ -52,10 +52,10 @@ protected void startUp() throws Exception {
         eventSubscriber.initialize();
         eventSubscriber.startAndWait();
         LOG.info("Successfully initialized eventSubscriber: {}",
-            eventSubscriber.getClass().getSimpleName());
+            eventSubscriber);
       } catch (Exception e) {
         LOG.error("Failed to initialize eventSubscriber: {}",
-            eventSubscriber.getClass().getSimpleName(), e);
+            eventSubscriber, e);
       }
     });
   }

diff --git a/cdap-app-fabric/src/main/java/io/cdap/cdap/internal/events/StartProgramEventSubscriber.java b/cdap-app-fabric/src/main/java/io/cdap/cdap/internal/events/StartProgramEventSubscriber.java
@@ -95,6 +95,23 @@ public void initialize() {
     }
   }
 
+  @Override
+  public String toString() {
+    if (readers == null || readers.isEmpty()) {
+      return this.getClass().getSimpleName();
+    }
+    StringBuilder sb = new StringBuilder();
+    sb.append("Subscriber: " + this.getClass().getSimpleName() + " ");
+    sb.append("EventReaders:\n\t");
+    for (EventReader<StartProgramEvent> reader : readers) {
+     sb.append(reader.getId());
+     sb.append(",");
+    }
+    // Get rid of trailing comma
+    sb.setLength(sb.length() - 1);
+    return sb.toString();
+  }
+
   @Override
   protected Scheduler scheduler() {
     return Scheduler.newFixedDelaySchedule(0,