add testids in wrangler part-2 #1239
Conversation
| @@ -22,9 +22,12 @@ import classnames from 'classnames'; | |||
| import uuidV4 from 'uuid/v4'; | |||
| import { Observable } from 'rxjs/Observable'; | |||
| import intersection from 'lodash/intersection'; | |||
| import { getDataTestid } from '../../../testids/TestidsProvider'; | |||
There was a problem hiding this comment.
Nit: This should probably be an absolute path throughout. There's not a strong relationship between the location of each component file and the testids functionality.
There was a problem hiding this comment.
Will update in all of the files.
There was a problem hiding this comment.
Replaced all of these relative imports with the following
LC_CTYPE=C sed -i '' -E "s~\'.*\/testids/TestidsProvider\'~\'@cdap-ui\/testids\/TestidsProvider\'~g" $(find app/cdap -type f)
"One sed to rule them all,
one sed to find them,
one sed to bring them all,
and in the files replace them."
| @@ -154,7 +154,8 @@ | |||
| "url-loader": "3.0.0", | |||
| "webpack": "4.41.2", | |||
| "webpack-cli": "3.3.10", | |||
| "webpack-livereload-plugin": "2.2.0" | |||
| "webpack-livereload-plugin": "2.2.0", | |||
| "yaml-jest": "^1.2.0" | |||
There was a problem hiding this comment.
Nit : Are we planning to use directly in any test files as JSON? Please clarify.
Also, Could you please update in the description about this change too, so that context would be clear when referred later?
There was a problem hiding this comment.
It's a dev-dependency required by jest (unit test runner) to be able to import the testids.yaml file. yaml-jest is a transformer that takes a yaml file and transforms it into a js module consumable by jest.
Add data-testids for wrangler directives
Description
Adds
data-testidattributes for all of the wrangler column directives.Also adds the dev-dependency
yaml-jest. It's required by jest (unit test runner) to be able to import thetestids.yamlfile.yaml-jestis a transformer that takes a yaml file and transforms it into a js module consumable by jest.PR Type
Links
Jira: CDAP-21039
Test Plan
NA
Screenshots
NA