Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show tooltip for pipeline runs based on app.run.records.ttl.days configuration #1236

Merged
merged 1 commit into from
Aug 1, 2024
Merged

Show tooltip for pipeline runs based on app.run.records.ttl.days configuration #1236

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion app/cdap/components/PipelineDetails/RunLevelInfo/CurrentRunIndex.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,8 @@ const CurrentRunIndex = ({
runsCount - (runs.length - currentRunIndex)
);

const runLimit = Number(window.CDAP_CONFIG.cdap.runRecordsTtl) || 0;

const pipelineLink = getHydratorUrl({
stateName: 'hydrator.detail',
stateParams: {
Expand Down Expand Up @@ -192,7 +194,16 @@ const CurrentRunIndex = ({

return (
<div className="run-number-container run-info-container">
<h4 className="run-number">
<h4
className="run-number"
title={
runLimit > 0
? T.translate(`${PREFIX}.tooltipRunLimit`, {
runLimit,
}).toString()
: ''
}
>
{T.translate(`${PREFIX}.currentRunIndex`, {
currentRunIndex: runIndexInTotalRunsCount + 1,
numRuns: runsCount,
Expand Down
1 change: 1 addition & 0 deletions app/cdap/text/text-en.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2505,6 +2505,7 @@ features:
noInfo: Profile information unavailable
runsCurrentlyRunning: Runs currently running - select one to view
status: Status
tooltipRunLimit: Pipeline runs for only the last {runLimit} days are displayed
warnings: Warnings
startTime: Start time
TopPanel:
Expand Down
1 change: 1 addition & 0 deletions server/express.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,6 +257,7 @@ function makeApp(authAddress, cdapConfig, uiSettings) {
hstsMaxAge: cdapConfig['hsts.max.age'],
hstsIncludeSubDomains: cdapConfig['hsts.include.sub.domains'],
hstsPreload: cdapConfig['hsts.preload'],
runRecordsTtl: cdapConfig['app.run.records.ttl.days'],
},
hydrator: {
previewEnabled: cdapConfig['enable.preview'] === 'true',
Expand Down
Loading