Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry pick #1222 Add tooltip for nullable checkbox in schema table #1223

Merged
merged 1 commit into from
Jun 28, 2024
Merged

Cherry pick #1222 Add tooltip for nullable checkbox in schema table #1223

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions app/cdap/components/AbstractWidget/SchemaEditor/RowButtons/Nullable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ import * as React from 'react';
import CheckBox from '@material-ui/core/Checkbox';
import CheckBoxIcon from '@material-ui/icons/CheckBox';
import CheckBoxOutlineBlankIcon from '@material-ui/icons/CheckBoxOutlineBlank';
import T from 'i18n-react';

interface INullableBaseProps {
nullable: boolean;
Expand All @@ -36,6 +37,7 @@ const NullableBase = ({ nullable, onNullable: onChange }: INullableBaseProps) =>
onChange(e.target.checked);
}}
disabled={typeof onChange !== 'function'}
title={T.translate('features.SchemaEditor.Tooltips.nullableCheckbox').toString()}
/>
);
};
Expand Down
2 changes: 2 additions & 0 deletions app/cdap/text/text-en.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3171,6 +3171,8 @@ features:
Labels:
fieldName: Field name
symbolName: Symbol name
Tooltips:
nullableCheckbox: Select to make the column nullable
ServiceEnableUtility:
serviceNotFound: Cannot find {artifactName} artifact
ServiceAccounts:
Expand Down
Loading