Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(CDAP-20647): Use SCM error message from backend directly #1054

Merged
merged 1 commit into from
Jul 12, 2023
Merged

fix(CDAP-20647): Use SCM error message from backend directly #1054

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/cdap/components/NamespaceAdmin/SourceControlManagement/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ export const SourceControlManagement = () => {
window.location.href = `/ns/${namespace}/scm/sync`;
},
(err) => {
setErrorMessage(T.translate(`${PREFIX}.invalidConfig`, { error: err.message }));
setErrorMessage(err.message);
setLoading(false);
},
() => {
Expand Down
4 changes: 1 addition & 3 deletions app/cdap/components/ResourceCenterEntity/ResourceCenterPipelineEntity.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,9 +121,7 @@ export default function ResourceCenterPipelineEntity({
dispatch({
type: 'SET_ERROR',
payload: {
error: T.translate('features.SourceControlManagement.invalidConfig', {
error: err.message,
}).toLocaleString(),
error: err.message,
},
});
dispatch({ type: 'SET_LOADING', payload: { loading: false } });
Expand Down
1 change: 0 additions & 1 deletion app/cdap/text/text-en.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3200,7 +3200,6 @@ features:
1: "{context} required field is missing"
_: "{context} required fields are missing"
info: Source control management allows you to connect namespace with the repository of your source control system repository to efficiently manage development process of the deployed pipelines.
invalidConfig: "{error}. Please validate saved source control management configurations."
linkButton: Link Repository
pull:
emptyPipelineListMessage: There are no pipelines in the remote repository or no pipelines matching the search query "{query}"
Expand Down