Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove lint-related codes #266

Merged
merged 4 commits into from
Dec 20, 2023

Conversation

SAutum
Copy link
Contributor

@SAutum SAutum commented Dec 12, 2023

fix: remove lint-related codes

Proposed changes: Remove the lint-related codes which are no longer in use.

@cburstedde
Copy link
Owner

Thanks!
If I run grep -r LINT . 2>/dev/null | grep -v Makefile\.in | egrep -v '^./(sc|.git)'
I get a couple more matches:

./configure.ac:dnl SC_PROG_LINT
./Makefile.am:LINT_CSOURCES =
./Makefile.am:## ALL_LINT_FLAGS = $(LINT_FLAGS) $(DEFS) $(DEFAULT_INCLUDES) $(INCLUDES) \
./Makefile.am:## if LINT
./Makefile.am:## 	for f in $(LINT_CSOURCES) ; do \
./Makefile.am:## 		$(LINT) $(ALL_LINT_FLAGS) $(top_srcdir)/$$f || \
./src/Makefile.am:LINT_CSOURCES += $(libp4est_compiled_sources)
./src/p4est_base.c:#ifndef SC_SPLINT
./test/Makefile.am:LINT_CSOURCES += \
./test/Makefile.am:LINT_CSOURCES += \

The related code can be removed entirely.

@cburstedde cburstedde marked this pull request as ready for review December 13, 2023 12:04
@cburstedde
Copy link
Owner

Thanks!

@cburstedde cburstedde merged commit 6ad45d2 into cburstedde:develop Dec 20, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants