Update libsc (with updated CMake logic) #256
Conversation
|
@scivision: wondering if there are any implications on the p4est CMake by latest libsc. Any ideas? Thanks! |
|
Interesting, this is an issue with Shared libraries, but only on macOS (Linux shared library is OK). This may be an interesting quirk of the linker. I see this same error on an Apple Silicon Mac (the CI is Intel Mac) |
cburstedde
force-pushed
the
test-develop
branch
from
f88291a
to
90e8707
Compare
|
I force-pushed to make libsc test ok with valgrind. Still wondering what this is about. :) |
ctest: provide LIBRARY_PATH with dynamic library dir fixes cburstedde#256
ctest: provide LIBRARY_PATH with dynamic library dir fixes cburstedde#256
|
This branch refers to the latest libsc with @scivision's PR merged. Ideally, development on top of this branch might get the CI to work with the current module setting. |
ctest: provide LIBRARY_PATH with dynamic library dir fixes #256
testing example standalone too is vital for checking that CMake packaging is working. Publish additional variables to the CMake P4est package necessary for using P4est from other CMake projects. This is an interim, fully compatible step for the next PR that will greatly streamline the CMake packaging from Forestclaw down to libsc.
CMake publishes packaging info with much greater fidelity than this. The new packaging will not use FindSC, FindP4EST at all.
ci:cmake: test with mpich and openmpi
|
I've bumped the test_develop branch with the available code from that other repository. |
|
One more thing that CMake may not yet be figuring out in all configurations is the convention for qsort_r: GNU or BSD. In particular, the defines |
Update libsc with updated CMake logic
I see a CMake failure on the CI. Han this be fixed?