p4est_search: fix to pass true quadrant #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the relatively new function p4est_search_reorder, we accept a parameter to switch level skipping on or off as an optimization. If on and only a single leaf is contained in a search quadrant, we directly skip down to the leaf as next quadrant to consider. We fix the bug that the quadrant was not real when skipping was off.
|
Any other comments on search_reorder? |
|
This looks good to @tim-griesbach and me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the relatively new function p4est_search_reorder, we accept a parameter to switch level skipping on or off as an optimization. If on and only a single leaf is contained in a search quadrant, we directly skip down to the leaf as next quadrant to consider.
We fix the bug that the quadrant was not real when skipping was off.