Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Box V2 webhook signature validation #129

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ryankon
Copy link
Contributor

@ryankon ryankon commented Dec 17, 2023

This fixes #127.

Outside of the "update task assignment" assertion that requires the test user to confirm their email, I've managed to get all the specs to pass by doing the following:

  1. Update webhook_validator_spec.rb to use the updated signature generation
  2. Updated passwords in files_spec.rb and folders_spec.rb to comply with updated password complexity requirements

Also, the thumbnail test transiently fails, so I added a comment to it.

@ryankon
Copy link
Contributor Author

ryankon commented Jan 9, 2024

@xhocquet Happy New Year! I wanted to follow up and see if we could get this merged in. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Boxr::WebhookValidator fails to validate V2 webhook signatures
1 participant