Skip to content

Commit

Permalink
replace deprecated nose dependency with pynose
Browse files Browse the repository at this point in the history
after upgrading teuthology to centos 9 and python 3.10, the rgw
multisite test suite now fails to invoke nosetests with:

> AttributeError: module 'collections' has no attribute 'Callable'

this is a known issue tracked in nose-devs/nose#1127

Shilpa found a new 'pynose' package which claims that:

> This version of nose is compatible with Python 3.7+ (including 3.13+).

replace the nose dependency that i initially added in
ceph#1069 with the current version
1.5.1 of pynose

to prepare this pr, i first changed setup.cfg then ran:

> ./update-requirements.sh -P "pynose==1.5.1"

Fixes: https://tracker.ceph.com/issues/66183

Signed-off-by: Casey Bodley <[email protected]>
  • Loading branch information
cbodley committed May 23, 2024
1 parent b9e3da8 commit 73a7948
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
6 changes: 3 additions & 3 deletions requirements.txt
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#
# This file is autogenerated by pip-compile with Python 3.11
# This file is autogenerated by pip-compile with Python 3.12
# by the following command:
#
# pip-compile --extra=test pyproject.toml
Expand Down Expand Up @@ -95,8 +95,6 @@ ndg-httpsclient==0.5.1
# via teuthology (pyproject.toml)
netaddr==0.9.0
# via teuthology (pyproject.toml)
nose==1.3.7
# via teuthology (pyproject.toml)
packaging==23.2
# via
# ansible-core
Expand Down Expand Up @@ -138,6 +136,8 @@ pynacl==1.5.0
# via
# paramiko
# teuthology (pyproject.toml)
pynose==1.5.1
# via teuthology (pyproject.toml)
pyopenssl==23.3.0
# via
# ndg-httpsclient
Expand Down
2 changes: 1 addition & 1 deletion setup.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ test =
coverage
ipy
mock
nose
pynose
pytest
pytest-cov
toml
Expand Down

0 comments on commit 73a7948

Please sign in to comment.