-
-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rentry.co): init #1227
base: main
Are you sure you want to change the base?
feat(rentry.co): init #1227
Conversation
Co-authored-by: uncenter <[email protected]>
Co-authored-by: isabelroses <[email protected]>
|
@uncenter regarding your review. thanks for suggesting shiki.style. i have added comments to explain the syntax highlighting styles. but there are innaccuracies that i couldn't fix because elements that should have different colors are using the same class. for example name = "test"
name.len()
|
Yeah there isn't anything you can do about that, just means Rentry.co is using some subpar highlighter. Thanks for doing those fixes, I'll review later. |
Omar see #1198 (comment) for the custom text colors. Mark is already themed. |
Co-authored-by: uncenter <[email protected]>
styles/rentry.co/catppuccin.user.css
Outdated
color: @subtext0; | ||
} | ||
.ne { | ||
color: @peach; | ||
} | ||
.nl { | ||
color: @yellow; | ||
} | ||
.nn { | ||
color: @text; | ||
} | ||
.w { | ||
color: @subtext1; | ||
} | ||
// Escape Sequences, Regex | ||
.se { | ||
color: @pink; | ||
} | ||
// Comments | ||
.c, | ||
.ch, | ||
.cm, | ||
.c1, | ||
.cs { | ||
color: @overlay2; | ||
} | ||
// Keyword | ||
.k, | ||
.kc, | ||
.kd, | ||
.kn, | ||
.kp, | ||
.kr, | ||
.nt, | ||
.sx, | ||
.bp, | ||
.kt { | ||
color: @mauve; | ||
} | ||
// Operators | ||
.o { | ||
color: @sky; | ||
} | ||
// Constants, Numbers | ||
.m, | ||
.mb, | ||
.mf, | ||
.mh, | ||
.mi, | ||
.mo, | ||
.il, | ||
.nb { | ||
color: @peach; | ||
} | ||
.gh, | ||
.gp { | ||
color: @sapphire; | ||
} | ||
// Strings | ||
.s, | ||
.sa, | ||
.sb, | ||
.sc, | ||
.dl, | ||
.s2, | ||
.sh, | ||
.sd, | ||
.s1, | ||
.cpf { | ||
color: @green; | ||
} | ||
.nc { | ||
color: @yellow; | ||
} | ||
// Methods, Functions | ||
.nf, | ||
.fm { | ||
color: @blue; | ||
} | ||
.nd, | ||
.ow { | ||
color: @mauve; | ||
} | ||
.nv, | ||
.ss, | ||
.vc, | ||
.vg, | ||
.vi, | ||
.vm { | ||
color: @text; | ||
} | ||
.si, | ||
.sr { | ||
color: @red; | ||
} | ||
pre { | ||
color: @text !important; | ||
} | ||
border-color: @surface0 !important; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry what is this again? Do we know what syntax highlighter produces this output?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
from the previous pull request
the syntax highlighting is using CodeMirror. and while there is a theme for it, it's not present in tips-and-tricks.md. also i think its outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is CodeMirror? I know the cm-x
stuff is, the editor stuff, but the rendered markdown code blocks that this themes is different right? It's outputting completely different markup.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe it's pygments?
(the website is apparently made using django)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah right looks like it. Can you theme it via https://github.com/catppuccin/userstyles/blob/main/docs/tips-and-tricks.md#pygments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess those are styles our Pygments port sets.
Co-authored-by: uncenter <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.text-warning-darker
is unthemed: put in def
as the URL for the doc and it gives a "Entry with this url already exists." warning.
.modal-content>.modal-header
is unthemed - try deleting a thingy, the header of the modal that pops up is unthemed.
styles/rentry.co/preview.webp
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the hassle but can we retake this with some demo text? You could just use the example page they link: https://rentry.co/example-3242785/edit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i chose the empty editor view because that's the first thing one sees when visiting rentry.co
this example page looks like a wall of text
Co-authored-by: uncenter <[email protected]>
🎉 Theme for Website 🎉
Rentry.co is a markdown paste service with preview, custom urls and editing.¹
💬 Additional Comments 💬
i opened a new pr because renaming the branch closed the old one (#1198). i should've done some research before doing so.
🗒 Checklist 🗒
/styles/<name-of-website>
containing the contents of the/template
directory.userstyles.yml
file with information about the new userstyle.
catppuccin.user.css
- all the CSS for the userstyle, based on thetemplate.
preview.webp
- composite image of all four individual flavor screenshots (taken with the default accent color of mauve) stitched together, generated via Catwalk.