Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rentry.co): init #1227

Open
wants to merge 37 commits into
base: main
Choose a base branch
from
Open

Conversation

thismoon
Copy link
Contributor

🎉 Theme for Website 🎉

Rentry.co is a markdown paste service with preview, custom urls and editing.¹

💬 Additional Comments 💬

i opened a new pr because renaming the branch closed the old one (#1198). i should've done some research before doing so.

🗒 Checklist 🗒

  • I have read and followed Catppuccin's submission guidelines.
  • I have made a new directory underneath /styles/<name-of-website> containing the contents of the /template directory.
    • I have ensured that the new directory is in lower-kebab-case.
    • I have followed the template and kept the preprocessor as LESS.
  • I have made sure to update the
    userstyles.yml
    file with information about the new userstyle.
  • I have included the following files:
    • catppuccin.user.css - all the CSS for the userstyle, based on the
      template.
    • preview.webp - composite image of all four individual flavor screenshots (taken with the default accent color of mauve) stitched together, generated via Catwalk.

@thismoon thismoon requested a review from a team as a code owner August 22, 2024 16:53
@thismoon
Copy link
Contributor Author

thismoon commented Aug 22, 2024

what's wrong with Typo Checker / Spellcheck checking for files i didn't touch?
i guess pulling from the main branch will fix it? would this break the pr?
i think i'll ignore it for now­­

apparently it's a common issue?

@thismoon
Copy link
Contributor Author

@uncenter regarding your review. thanks for suggesting shiki.style. i have added comments to explain the syntax highlighting styles. but there are innaccuracies that i couldn't fix because elements that should have different colors are using the same class. for example

name = "test"
name.len()

image
image
name (a variable) and len() (a function) are using the same class (.n). i'm not sure if i can do something about this

@uncenter
Copy link
Member

Yeah there isn't anything you can do about that, just means Rentry.co is using some subpar highlighter. Thanks for doing those fixes, I'll review later.

@uncenter
Copy link
Member

Omar see #1198 (comment) for the custom text colors. Mark is already themed.

styles/rentry.co/catppuccin.user.css Outdated Show resolved Hide resolved
isabelroses
isabelroses previously approved these changes Sep 3, 2024
styles/rentry.co/catppuccin.user.css Outdated Show resolved Hide resolved
styles/rentry.co/catppuccin.user.css Outdated Show resolved Hide resolved
styles/rentry.co/catppuccin.user.css Outdated Show resolved Hide resolved
styles/rentry.co/catppuccin.user.css Outdated Show resolved Hide resolved
Co-authored-by: uncenter <[email protected]>
isabelroses
isabelroses previously approved these changes Sep 11, 2024
styles/rentry.co/catppuccin.user.css Outdated Show resolved Hide resolved
styles/rentry.co/catppuccin.user.css Outdated Show resolved Hide resolved
styles/rentry.co/catppuccin.user.css Outdated Show resolved Hide resolved
Comment on lines 357 to 498
color: @subtext0;
}
.ne {
color: @peach;
}
.nl {
color: @yellow;
}
.nn {
color: @text;
}
.w {
color: @subtext1;
}
// Escape Sequences, Regex
.se {
color: @pink;
}
// Comments
.c,
.ch,
.cm,
.c1,
.cs {
color: @overlay2;
}
// Keyword
.k,
.kc,
.kd,
.kn,
.kp,
.kr,
.nt,
.sx,
.bp,
.kt {
color: @mauve;
}
// Operators
.o {
color: @sky;
}
// Constants, Numbers
.m,
.mb,
.mf,
.mh,
.mi,
.mo,
.il,
.nb {
color: @peach;
}
.gh,
.gp {
color: @sapphire;
}
// Strings
.s,
.sa,
.sb,
.sc,
.dl,
.s2,
.sh,
.sd,
.s1,
.cpf {
color: @green;
}
.nc {
color: @yellow;
}
// Methods, Functions
.nf,
.fm {
color: @blue;
}
.nd,
.ow {
color: @mauve;
}
.nv,
.ss,
.vc,
.vg,
.vi,
.vm {
color: @text;
}
.si,
.sr {
color: @red;
}
pre {
color: @text !important;
}
border-color: @surface0 !important;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry what is this again? Do we know what syntax highlighter produces this output?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from the previous pull request

the syntax highlighting is using CodeMirror. and while there is a theme for it, it's not present in tips-and-tricks.md. also i think its outdated.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is CodeMirror? I know the cm-x stuff is, the editor stuff, but the rendered markdown code blocks that this themes is different right? It's outputting completely different markup.

Copy link
Contributor Author

@thismoon thismoon Sep 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe it's pygments?
(the website is apparently made using django)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

@thismoon thismoon Sep 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that worked. i should've used it from the start but there were no signs that it uses pygments (i expected a class name)
but why did the lines height change? and the background of the lines numbers is darker?
before:
image
after:
image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess those are styles our Pygments port sets.

styles/rentry.co/catppuccin.user.css Show resolved Hide resolved
Co-authored-by: uncenter <[email protected]>
isabelroses
isabelroses previously approved these changes Sep 25, 2024
Copy link
Member

@uncenter uncenter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.text-warning-darker is unthemed: put in def as the URL for the doc and it gives a "Entry with this url already exists." warning.

.modal-content>.modal-header is unthemed - try deleting a thingy, the header of the modal that pops up is unthemed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the hassle but can we retake this with some demo text? You could just use the example page they link: https://rentry.co/example-3242785/edit.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i chose the empty editor view because that's the first thing one sees when visiting rentry.co
this example page looks like a wall of text

styles/rentry.co/catppuccin.user.css Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants