-
-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(readwise): init #1130
base: main
Are you sure you want to change the base?
feat(readwise): init #1130
Conversation
Closes catppuccin/catppuccin#2479 |
@uncenter Thank you for the review, I've approved all the changed, the only doubt is about the domain change, as I've described in the thread there. |
Please don't update this branch unnecessarily! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Going off of the preview image you have provided, a few things need work. The grid of blue and white squares should be themed. The text color should be text instead of rosewater. The lightning bolt in the top right should be themed.
4331515
to
c24f8ba
Compare
@uncenter @isabelroses all the comments are resolved, preview image is updated both in the PR content and description |
ca5547b
to
3b379af
Compare
@uncenter @isabelroses PR is updated, comments are resolved |
No need to force push FYI. We squash merge so your commits in PRs don't matter much. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: uncenter <[email protected]>
@uncenter thank you for your help and careful review, I will resolve those design issues soon and will update my PR |
@uncenter changes are applied |
@isabelroses You are right, sorry for skipping that. Went through different UI elements on the page: search icon, chevron icon, scroll bar and styled them according to the style guide |
That bar with the tabs above it looks unthemed, as well as the background color of the details of that one book you have selected. |
@uncenter thx for the feedback, issues are resolved |
@uncenter @isabelroses Hi! Is there is anything I can help with to make it merged? |
🎉 Theme for Readwise 🎉
Readwise helps you get the most out of what you read by making it fun & easy to revisit your highlights from all your favorite reading platforms in one place. Quickly synchronize your highlights from Kindle, Apple Books, Instapaper, Pocket, Medium, Goodreads, and even paper books.
🗒 Checklist 🗒
/styles/<name-of-website>
containing the contents of the/template
directory.userstyles.yml
file with information about the new userstyle.
catppuccin.user.css
- all the CSS for the userstyle, based on thetemplate.
preview.webp
- composite image of all four individual flavor screenshots stitched together,generated via Catwalk.