Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(fuzzel): correctly gatekeep module #370

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(fuzzel): correctly gatekeep module #370

wants to merge 1 commit into from
+2 −1

Conversation

isabelroses
Copy link
Member

No description provided.

@isabelroses
Copy link
Member Author

build is failing on darwin due to spotify-player

getchoo
getchoo requested changes Nov 13, 2024
View reviewed changes
Copy link
Member

@getchoo getchoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The upstream module already gates this behind programs.fuzzel.enable. This shouldn't be needed

@isabelroses
Copy link
Member Author

The upstream module already gates this behind programs.fuzzel.enable. This shouldn't be needed

the same could be said for fish and others but we do the same thing

nix/modules/home-manager/fish.nix

Line 5 in 32359bf

enable = cfg.enable && config.programs.fish.enable;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@getchoo getchoo getchoo requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@isabelroses @getchoo