Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: update platformVersion to 2022.2 #88

Merged

Conversation

quentinguidee
Copy link
Member

@quentinguidee quentinguidee commented Oct 1, 2023

This PR moves away from IntelliJ 2021, as this is really hard to work on the UI with IntelliJ 2021 that does not have the new UI. And while a lot of users have move to the new UI, this PR seems important to improve the quality of next releases.

The new platformVersion with this PR is 2023.2 2022.2.

@quentinguidee quentinguidee mentioned this pull request Oct 1, 2023
4 tasks
Copy link
Contributor

@sgoudham sgoudham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey 👋, thanks for updating the version - I agree!

I believe updating these values will affect what versions our users can install the plugin on. With regards to the version table below - I think we should use pluginSinceBuild: 222 and platformVersion: 2022.2 as that is the minimum release required for Java 17 and the next year up from 2021.

image

What do you think?

@quentinguidee quentinguidee changed the title chore: update platformVersion to 2023.2 chore: update platformVersion to 2022.2 Oct 1, 2023
@sgoudham sgoudham changed the title chore: update platformVersion to 2022.2 build: update platformVersion to 2022.2 Oct 1, 2023
@sgoudham sgoudham merged commit 489f639 into catppuccin:main Oct 1, 2023
1 check passed
@quentinguidee quentinguidee deleted the chore/update-intellij-2023.2 branch October 1, 2023 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants