Skip to content

Commit

Permalink
Merge pull request #38 from catchpoint/changelogAdded
Browse files Browse the repository at this point in the history 
changelog updated
  • Loading branch information
@vikashkuma
vikashkuma authored May 15, 2024
2 parents f1519a1 + ecf19f1 commit f4b3338
Showing 1 changed file with 7 additions and 0 deletions.
7 changes: 7 additions & 0 deletions changelog.md
View file
Original file line number Diff line number Diff line change
@@ -1,3 +1,10 @@
# v1.0.1

Catchpoint internal testing:

* Bug 187721: [Terraform] Import command fails when the alert settings are set to Override
* Bug 188869: [Terraform] Update operation in terraform without any changes, displays 1 change applied message

# v1.0.0

BUG FIXES:
Expand Down

3 comments on commit f4b3338

@dmarkus88
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. These changes are backwards incompatible - is adding a patch version number appropriate to indicate breaking API changes? (required fields that weren't there before for start_time and end_time)

  2. Please note that after upgrading the provider version to 1.0.1 and adding the required fields, I can no longer create new web_test resources. How is the 1.0.1 release tested?

Screenshot 2024-05-15 at 10 53 12 AM Screenshot 2024-05-15 at 10 55 03 AM

@vikashkuma
Copy link
Contributor Author

@vikashkuma vikashkuma commented on f4b3338 May 16, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dmarkus88 This is just for Catchpoint internal testing, I have mentioned in the changelog.
The reason to add startTime as a mandetory field to solve one issue.
When client run second time terraform apply command without any changes start time was getting changed.
And I am able to create a web test in v1.0.1.
its a humble request to you to please use the terraform version which catchpoint will announce or we will add in the read me and changelog file both.
418878d4-2b03-42a2-91ec-49887c21ae77

@dmarkus88
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Understood - thank you for the explanation. Is there a reason that the internal testing release is published to the terraform registry?

Request understood, and thank you for communicating expectations. However, this isn't the standard practice for terraform modules in the community.

If you're interested, here's a great resource from the vendor: https://developer.hashicorp.com/terraform/plugin/best-practices/versioning

https://registry.terraform.io/providers/catchpoint/catchpoint/1.0.1

Please sign in to comment.