Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add -Wdouble-promotion to common warnings #2707

Open
wants to merge 1 commit into
base: devel
Choose a base branch
from

Conversation

teksturi
Copy link

This has not huge benefits in Catch2 codebase, but it is still easy to take in use and it will benefit those which build catch2 with project default compiler options.

Description

GitHub Issues

This has not huge benefits in Catch2 codebase, but it is still easy to
take in use and it will benefit those which build catch2 with project
default compiler options.

Signed-off-by: Kari Argillander <[email protected]>
@horenmar
Copy link
Member

I am probably willing to merge it, but you need to

  • update approval tests
  • fix all instances of the warnings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants