Removed unnecessary import checks for scipy, h5py, and zarr #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pauladkisson
changed the title
h-mayorquin
approved these changes
Sep 20, 2024
I haven't noticed install time as a problem, how did it come up for spikeinterface? |
|
Importing times, not installing times. We have a test for import times in the CI of SI: |
Interesting, I'll have to look into this, but for now I'm going to keep imports where they are. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #316
As well as h5py and zarr. sima checks are kept bc they are not installed in requirements bc it is gpl.