Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added depth_slice for volumetricImagingExtractors #363

Merged
merged 12 commits into from
Sep 24, 2024
Merged

Added depth_slice for volumetricImagingExtractors #363

merged 12 commits into from
Sep 24, 2024

Conversation

pauladkisson
Copy link
Member

Fixes #301

weiglszonja
weiglszonja reviewed Sep 23, 2024
View reviewed changes
Copy link
Contributor

@weiglszonja weiglszonja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for working on this @pauladkisson!
If you agree, can you add a test where you use depth_slice() on a DepthSliceVolumetricImagingExtractor?
Can you also test frame_slice() on a DepthSliceVolumetricImagingExtractor?

@pauladkisson
Copy link
Member Author

If you agree, can you add a test where you use depth_slice() on a DepthSliceVolumetricImagingExtractor?

Done!

Can you also test frame_slice() on a DepthSliceVolumetricImagingExtractor?

Unfortunately, frame_slice's get_video isn't compatible with VolumetricImagingExtractor bc it uses a channel argument. I'm working on a fairly large (backward-breaking) PR to fix these sorts of issues and streamline the API (0.6.0). But, it may take a bit before that's ready, so for now I just added a notimplementederror.

weiglszonja
weiglszonja approved these changes Sep 24, 2024
View reviewed changes
Copy link
Contributor

@weiglszonja weiglszonja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@pauladkisson pauladkisson merged commit b383d7b into main Sep 24, 2024
29 checks passed
@pauladkisson pauladkisson deleted the depth_slice branch September 24, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weiglszonja weiglszonja weiglszonja approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature]: Depth Slice for VolumetricImagingExtractor
2 participants
@pauladkisson @weiglszonja