Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Close issue 117 #315

Merged
merged 9 commits into from
Apr 23, 2024
Merged

Close issue 117 #315

merged 9 commits into from
Apr 23, 2024

Conversation

h-mayorquin
Copy link
Collaborator

This should fix #117

@h-mayorquin h-mayorquin self-assigned this Apr 23, 2024
@h-mayorquin
Copy link
Collaborator Author

@pauladkisson @CodyCBakerPhD this is ready, what's your policy here regarding the changelog.

@pauladkisson
Copy link
Member

Looks good, thanks for taking care of this.

Re Changelog: Just add something under Fixes like "Removed unnecessary scipy import error handling"

@h-mayorquin
Copy link
Collaborator Author

@pauladkisson thanks, done.

@pauladkisson pauladkisson merged commit 8cbd175 into main Apr 23, 2024
18 checks passed
@pauladkisson pauladkisson deleted the remove_try_except_scipy branch April 23, 2024 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pauladkisson pauladkisson pauladkisson approved these changes

Assignees

@h-mayorquin h-mayorquin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove special import in extraction_tools after dropping python 3.7 support
2 participants
@h-mayorquin @pauladkisson