drop python 3.8 (#325)

* drop python 3.8

* fix typo

* Update CHANGELOG.md

* Update CHANGELOG.md

* fix typo

.github/ISSUE_TEMPLATE/bug_report.yml

@@ -60,7 +60,7 @@ body:
     attributes:
       label: Python Version
       options:
-        - "3.8"
+        - "3.8 (no longer supported)"
         - "3.9"
         - "3.10"
         - "3.11"

.github/workflows/auto-publish.yml

@@ -15,7 +15,7 @@ jobs:
       - name: Set up Python
         uses: actions/setup-python@v2
         with:
-          python-version: "3.8"
+          python-version: "3.9"
       - name: Install dependencies
         run: |
           python -m pip install --upgrade pip

.github/workflows/dev-testing.yaml

@@ -14,7 +14,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        python-version: ["3.8", "3.9", "3.10", "3.11", "3.12"]
+        python-version: ["3.9", "3.10", "3.11", "3.12"]
     steps:
       - uses: actions/checkout@v4
       - run: git fetch --prune --unshallow --tags

.github/workflows/run-tests.yml

@@ -31,7 +31,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        python-version: ["3.8", "3.9", "3.10", "3.11", "3.12"]
+        python-version: ["3.9", "3.10", "3.11", "3.12"]
         os: [ubuntu-latest, windows-latest, macos-latest, macos-13] # macos-13 is the latest version of macOS with Intel chip
     steps:
       - uses: actions/checkout@v4

CHANGELOG.md

@@ -1,12 +1,16 @@
-# Upcoming
+# Upcoming (v0.6.0)
+
+### Back-compatibility break
+
+* Remove support for Python 3.8 [PR #325](https://github.com/catalystneuro/roiextractors/pull/325)
 
 ### Features
 
 * Updated testing workflows to include python 3.12, m1/intel macos, and dev tests to check neuroconv: [PR #317](https://github.com/catalystneuro/roiextractors/pull/317)
 
 ### Fixes
 
-* Remove unecessary scipy import error handling [#315]((https://github.com/catalystneuro/roiextractors/pull/315)
+* Remove unecessary scipy import error handling [#315](https://github.com/catalystneuro/roiextractors/pull/315)
 
 * Added daily testing workflow and fixed bug with python 3.12 by upgrading scanimage-tiff-reader version: [PR #321](https://github.com/catalystneuro/roiextractors/pull/321)
 

src/roiextractors/__init__.py

@@ -1,16 +1,8 @@
 """Python-based module for extracting from, converting between, and handling recorded and optical imaging data from several file formats."""
 
-# Keeping __version__ accessible only to maintain backcompatability.
-# Modern approach (Python >= 3.8) is to use importlib
-try:
-    from importlib.metadata import version
-
-    __version__ = version("roiextractors")
-except ModuleNotFoundError:  # Remove the except clause when minimal supported version becomes 3.8
-    from pkg_resources import get_distribution
-
-    __version__ = get_distribution("roiextractors").version
+from importlib.metadata import version
 
+__version__ = version("roiextractors")
 
 from .example_datasets import toy_example
 from .extraction_tools import show_video