Skip to content

Commit

Permalink
Refactor Workflows (#336)
Browse files Browse the repository at this point in the history
* update dailies email notif subject line

* refactored changelog check to its own workflow

* updated changelog
  • Loading branch information
pauladkisson authored May 22, 2024
1 parent 6c6b30f commit df649c0
Show file tree
Hide file tree
Showing 4 changed files with 23 additions and 17 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/dailies.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -26,5 +26,5 @@ jobs:
password: ${{ secrets.MAIL_PASSWORD }}
subject: ROIExtractors Daily Failure
to: ${{ secrets.DAILY_FAILURE_EMAIL_LIST }} # add more with commas, no separation
from: NWB Inspector
from: ROIExtractors
body: "The daily workflow for ROIExtractors failed: please check status at https://github.com/catalystneuro/roiextractors/actions/workflows/dailies.yaml"
21 changes: 21 additions & 0 deletions .github/workflows/detect-changelog-updates.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
name: Detect Changelog Updates
on:
pull_request:
workflow_dispatch:

jobs:
assess-file-changes:
uses: ./.github/workflows/assess-file-changes.yml

detect-changelog-updates:
needs: assess-file-changes
if: ${{ needs.assess-file-changes.outputs.SOURCE_CHANGED == 'true' }}
name: Auto-detecting CHANGELOG.md updates
runs-on: ubuntu-latest
steps:
- if: ${{ needs.assess-file-changes.outputs.CHANGELOG_UPDATED == 'true' }}
run: echo "CHANGELOG.md has been updated."
- if: ${{ needs.assess-file-changes.outputs.CHANGELOG_UPDATED == 'false' }}
run: |
echo "CHANGELOG.md has not been updated."
0
16 changes: 0 additions & 16 deletions .github/workflows/run-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,22 +9,6 @@ concurrency:
cancel-in-progress: true

jobs:
assess-file-changes:
uses: ./.github/workflows/assess-file-changes.yml

detect-changelog-updates:
needs: assess-file-changes
if: ${{ needs.assess-file-changes.outputs.SOURCE_CHANGED == 'true' }}
name: Auto-detecting CHANGELOG.md updates
runs-on: ubuntu-latest
steps:
- if: ${{ needs.assess-file-changes.outputs.CHANGELOG_UPDATED == 'true' }}
run: echo "CHANGELOG.md has been updated."
- if: ${{ needs.assess-file-changes.outputs.CHANGELOG_UPDATED == 'false' }}
run: |
echo "CHANGELOG.md has not been updated."
0
run:
name: Full tests on ${{ matrix.os }} with Python ${{ matrix.python-version }}
runs-on: ${{ matrix.os }}
Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@

* Remove unnecessary `scipy` import error handling: [#315](https://github.com/catalystneuro/roiextractors/pull/315)
* Fixed the typing returned by the `InscopixImagingExtractor.get_dtype` method: [#326](https://github.com/catalystneuro/roiextractors/pull/326)
* Detect Changelog Updates was moved to its own dedicated workflow to avoid daily testing failures: [#336](https://github.com/catalystneuro/roiextractors/pull/336)

### Improvements

Expand Down

0 comments on commit df649c0

Please sign in to comment.