Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create specs #1
Create specs #1
Changes from 15 commits
0a1cb88
00158e1
97270d4
7ae8983
d70ab9e
c5eb8a1
f5f3846
6014db6
d1c59a7
273cee0
6296281
c5791ed
fd9b78c
1339c62
486c0a5
5122ae8
fadb936
7c2f36f
f30c6fb
1bb58da
a426f08
76d02c7
1122c78
c5d99e5
385bdcc
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All microscopes have a DOI? I don't think I've ever seen that in the methods/supplemental section
How would I look it up for a particular microscope?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was meant to be there just for custom microscopes. I remember we discussed this a while ago, but I am also not totally convinced that this is something needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would a home-built microscope have a
manufacturer
ormodel
number?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably not 😑, I need to change this 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where are we at on this? Does the base PyNWB device has the
manufacturer
then you add themodel
to the newBaseModel
?