Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve tutorial and set the shape of dynamic region to null #13

Merged
merged 3 commits into from
Jul 13, 2024
Merged

Improve tutorial and set the shape of dynamic region to null #13

merged 3 commits into from
Jul 13, 2024

Conversation

h-mayorquin
Copy link
Collaborator

Two things in this PR:

  1. The first is to improve the tutorial by eliminate the use of mocks. Normal construction of the nwbfile object is used through pynwb API is usted instead.
  2. Eliminate shape and dimension of the units_region as I realized that the electodres attribute in the ElectricalSeries object does not have that and I suspect it was giving me errors in Link to units table in psths and add documentation to psth functions dicarlo-lab-to-nwb#20.

@h-mayorquin h-mayorquin self-assigned this Jul 12, 2024
@h-mayorquin h-mayorquin mentioned this pull request Jul 13, 2024
Merged
@h-mayorquin h-mayorquin merged commit f032b96 into main Jul 13, 2024
5 checks passed
@h-mayorquin h-mayorquin deleted the improve_tutorial branch July 13, 2024 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@h-mayorquin h-mayorquin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@h-mayorquin