Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements after Ben review #11

Merged
merged 1 commit into from
Apr 2, 2024
Merged

Improvements after Ben review #11

merged 1 commit into from
Apr 2, 2024

Conversation

h-mayorquin
Copy link
Collaborator

Some improvements after discussing with @bendichter this morning.

  • Simpify the __init__ of the class.
  • Specificy that the "milliseconds_from_event_to_first_bin` is to the beginning of the first bin on the documentation.
  • Remove non useful parenthesis on the docval for the unit table region.
  • number_of_event_repetitions to number_of_events.
  • Add description as an attribute.

@bendichter bendichter self-requested a review April 2, 2024 01:09
@h-mayorquin h-mayorquin merged commit 9b2e8f9 into main Apr 2, 2024
34 checks passed
@h-mayorquin h-mayorquin deleted the improve_init branch April 2, 2024 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bendichter bendichter bendichter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@h-mayorquin @bendichter