Add API consistency checks #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@grg2rsr You've also been added as a collaborator, so if you like this PR, feel free to clone the CN repo (not the IBL fork) to do the rest of the work on 'filling in the rest' by uncommenting the blocks and adjusting them to the suggested structure |
Closed
|
should I commit my changes to this branch, or make a new one? |
|
@grg2rsr If you want to be fancy, you could branch from this branch and open a PR with this branch as its base Whichever is easier for you though |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Would replace #77
@grg2rsr The uncommented blocks here show how I imagine integrating the consistency checks between NWB and ONE as a part of the file creation process (prior to DANDI upload)
Let me know what you think