feat(balance): gain dodge experience at reduced rate on taking hits #5694
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Required
main
so it won't cause conflict when updatingmain
branch later.Optional
Purpose of change
One noted issue with dodging is that failed dodges don't generate any EXP, only successful ones. This may be a potential issue since base dodge rate has recently been nerfed, and not every player can count on book-grinding using the recently-buffed books (nor do we want book-grinding to be the optimal solution).
A quick search through the files confirms that melee attacks do generate EXP at a reduced rate when you miss, so it's perfectly reasonable to allow failed dodges to also generate EXP at a reduced rate.
Describe the solution
Character::on_hit
so that getting hit by an attack still practices dodge skill, at half the EXP gained inCharacter::on_dodge
. Unlike the on-dodge one it's set to silence messages about not gaining EXP if you're being slapped by attacks too pathetic to learn anything from (though in practice if you can't learn dodging EXP from it then you're in a weird situation if you're still getting hit by it a bunch of times).Describe alternatives you've considered
Making it grant 25% the EXP of a successful dodge or some other further reduction below 50%.
Testing
Additional context