feat(balance): rare itemgroup has good items, only spawn it in armories #5668
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Required
main
so it won't cause conflict when updatingmain
branch later.Purpose of change
Rare was being rolled in spider basements, rat caves, and specific map extras. This PR is a tradeoff that ensures only good items are in the item group, but it only spawns in lab and military armories.
Describe the solution
Labs have 61 shelves, each has a 2% chance to roll once. Military bases have two rolls at 20% but military bases already can spawn power armor and other good guns. I took all the garbage items out so no more computer parts or pants. I replaced world spawns of "rare" with "military"
Describe alternatives you've considered
More locations and more rare loot table changes
Testing
Tests, primarily. Here's what 1000 rare spawns look like.
Additional context
The inevitable result of me getting tired of plasma rifle spawns in the forest. Someone will put it back later I'm sure, which is fine for modded runs.