Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(UI): add external tileset sprites for sails, adjust mounted flag background tiles #5376

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

chaosvolt
Copy link
Member

Checklist

Required

Optional

Purpose of change

Gives sails some less silly sprites and changes the background tile for vehiclepart mounted flags, as I felt the "standard red car roof" looked a bit weird on a lot of other vehicles.

Describe the solution

  1. Added a UDP external tileset sprite for vehicle sails that overrides the existing one, giving it a background instead of being a sail and small mast floating on nothingness.
  2. Added a sprite for large sails, taking advantage of the fact that we have a limited ability to do multi-tile sprites for tilesets so long as you respect layering priority (i.e. only extend into tiles left of the tile the sprite's on, not to the right).
  3. Misc: Changed the background tile for vehicle-mounted flags from bright vehicle red to a dark neutral background color.

Describe alternatives you've considered

Overriding the sail sprite itself directly in UDP itself because it will probably take an eternity for us to other get an update sent over from the Unpacked repo.

Testing

  1. Checked affected files for syntax and lint errors.
  2. Load-tested in compiled test build.
  3. Temporarily added in a lil pirate sloop to spawn in to test that it looks good at a glance.

image

Additional context

I'm too eepy to keep up the "translate the PR text into pirate-speak" gag I did last PR even though it's still very early into Talk Like A Pirate Day.

@github-actions github-actions bot added JSON related to game datas in JSON format. mods PR changes related to mods. labels Sep 19, 2024
Copy link
Collaborator

@RoyalFox2140 RoyalFox2140 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Classic 4am Chaos PR

@chaosvolt chaosvolt merged commit 6c958ec into cataclysmbnteam:main Sep 19, 2024
9 checks passed
@chaosvolt chaosvolt deleted the sprite-assignment-stuff branch September 19, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JSON related to game datas in JSON format. mods PR changes related to mods.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants