Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(mods/pride_flags): Consistency between furniture and item pride flags #5366

Merged
merged 3 commits into from
Sep 17, 2024

Conversation

RobbieNeko
Copy link
Contributor

Checklist

Required

Purpose of change

As Chaosvolt mentioned in the original PR, the descriptions for the hoisted pride flags were a bit basic. I felt that it'd be a good idea to just use the already-existing explanations of the meaning behind each flag, especially as it makes them more consistent.

Describe the solution

  • Adds the flavor to the furniture descriptions from the item-based flags for consistency and less basic-ness
  • Also makes a couple stylistic changes to the item flags' descriptions while I had noticed them

Describe alternatives you've considered

  • Further strip the explanation of the meaning behind the gradient from the autistic pride flag

I think it's kinda just restating the fact that it's a pride flag, and is ultimately a nothing-sentence, but it felt a little more valid than the acknowledgement of color theory haha

Testing

Just text changes, worst that'll happen is it gets mad at me for somehow missing a double-space after punctuation.

Additional context

Sorry, probably could've just slotted this into Chaos' PR as suggestions if I'd been a bit quicker on it. Then again, I suppose it does no harm to have it be an extra PR either.

consistency ftw
Smol style updates
@github-actions github-actions bot added JSON related to game datas in JSON format. mods PR changes related to mods. labels Sep 17, 2024
@chaosvolt chaosvolt merged commit 779ad16 into cataclysmbnteam:main Sep 17, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JSON related to game datas in JSON format. mods PR changes related to mods.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants