Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored/ Corrected a part of Documentation #1851

Merged
merged 2 commits into from
Apr 3, 2024

Conversation

ashishakkumar
Copy link
Contributor

@ashishakkumar ashishakkumar commented Apr 3, 2024

  • At line 259 : no such file (usage-encode.md) exists.
  • At line 266, 275, 283,293 :
    Below is the screenshot of pyserini/index/faiss.py file
Screenshot 2024-04-03 at 10 44 59 PM

It expects a Folder containing the file, not the file path.

I have other suggestions as well. Starting from this small contribution. More can be expected soon as I'm actively using this. Thank you

@lintool
Copy link
Member

lintool commented Apr 3, 2024

Thanks for your PR! Additional improvements most definitely welcome!

@lintool lintool merged commit be7d750 into castorini:master Apr 3, 2024
@ashishakkumar ashishakkumar deleted the skip-packaging-option branch April 3, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants