Fix data-eating behavior of Repo.ReadNames() and friends
#73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is a bad idea to drastically change the semantics of a function depending on (the number of) its arguments, especially if it's variadic. Split Repo.ReadNames() into two separate functions with fixed semantics, and inspect every call site to use one or the other accordingly.
It does not really matter because all errors are eaten by the handler, but still a good thing to do for uniformity.
|
Looks good! Many thanks for your contribution @intelfx! |
cassava
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not overload semantics of functions based on its parameters, especially if it's a variadic.
Fixes #71.