Disable integer sign extensions #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ACStoneCL this might be worth a doc |
deuszex
approved these changes
May 30, 2024
deuszex
pushed a commit
that referenced
this pull request
Jun 17, 2024
* Update to recent (post 1.69) nightly * Build without LLVM sign extensions * Satisfy clippy
deuszex
pushed a commit
that referenced
this pull request
Jun 17, 2024
* Update to recent (post 1.69) nightly * Build without LLVM sign extensions * Satisfy clippy
deuszex
added a commit
that referenced
this pull request
Aug 27, 2024
* WIP * WIP * Commit toolchain for ci/cd * Disable integer sign extensions (#139) * Update to recent (post 1.69) nightly * Build without LLVM sign extensions * Satisfy clippy * Disable integer sign extensions (#139) * Update to recent (post 1.69) nightly * Build without LLVM sign extensions * Satisfy clippy * WIP * 2.0.0-rc2 * 2.0.0-rc2 stable * addressing comments, first round of fixture fights * rc3 * fixture work * fixedture * Small review changes * Small rename * native eventing (#145) * native eventing * change_event_mode * native eventing done * Use DEFAULT_ACCOUNTS in tests (#146) * disallow Key::AddressableEntity::SmartContract in favour of Key::Package, should have been this way to begin with * more event tests * fix fake positive event test * remove unused dictinary location check * failing test * native expansive error topic * fix allowance migration * fix sec migration * removed custom error to see source behind it * fixed migration of contract packages * Update utils.rs * added compatibility mode * added content from community-rc3 branch * removed * addressed commit responses + removed migration --------- Co-authored-by: gRoussac <[email protected]> Co-authored-by: Rafał Chabowski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the build script to build WASM without the unuspported opcodes. It also updates the pinned nightly to
2024-05-28to show that this solution works with nightly toolchains based on Rust newer than 1.69.Fixes: casper-network/casper-node#4574
Running:
should result in
Rationale:
This is caused by the sign extension feature in code generator (LLVM)
i32.extend8_sis the opcode number 192 (0xc0).These are enabled by default in LLVM 16 which is used in Rust starting from 1.70.
We can dodge that by setting the
target-cpu=mvpflag, but since this affectsstdwhich comes as a prebuilt package, we also need to rebuildstdourselves.Hence we need sources:
rustup component add rust-srcand appropriately modified build script.
Actually, it should be enough to set
-C target-feature=-sign-ext, but this still produces thei32.extend8_sopcode (as can be seen in the compiler explorer here (not my link, though) - https://godbolt.org/z/Te5fczPhMCould be an issue in the LLVM itself, we should keep an eye on this.