Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the build script to build WASM without the unuspported opcodes. It also updates the pinned nightly to
2024-05-28
to show that this solution works with nightly toolchains based on Rust newer than 1.69.Fixes: casper-network/casper-node#4574
Running:
should result in
Rationale:
This is caused by the sign extension feature in code generator (LLVM)
i32.extend8_s
is the opcode number 192 (0xc0).These are enabled by default in LLVM 16 which is used in Rust starting from 1.70.
We can dodge that by setting the
target-cpu=mvp
flag, but since this affectsstd
which comes as a prebuilt package, we also need to rebuildstd
ourselves.Hence we need sources:
rustup component add rust-src
and appropriately modified build script.
Actually, it should be enough to set
-C target-feature=-sign-ext
, but this still produces thei32.extend8_s
opcode (as can be seen in the compiler explorer here (not my link, though) - https://godbolt.org/z/Te5fczPhMCould be an issue in the LLVM itself, we should keep an eye on this.